Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 1498793002: [iOS] Disable parts of TestNonDottedAndTLD cookie store unittest. (Closed)

Created:
5 years ago by droger
Modified:
5 years ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS] Disable parts of TestNonDottedAndTLD cookie store unittest. This test was already partially disabled on iOS (using the |supports_non_dotted_domains| parameter). This CL disables a larger part of the test, to unblock the commit queue. TBR=ellyjones BUG=564543 Committed: https://crrev.com/3e043848b6ef6fc7b2dae0a83c98db9331799dd1 Cr-Commit-Position: refs/heads/master@{#362946}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -10 lines) Patch
M net/cookies/cookie_store_unittest.h View 4 chunks +6 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
droger
marq: do you think it is fine to TBR this? These failing tests are blocking ...
5 years ago (2015-12-03 10:15:36 UTC) #3
droger
Retried with a clobber, lets hope that it will not skip the test.
5 years ago (2015-12-03 10:22:36 UTC) #4
droger
Ok, clobbering does not change anything, test still skipped.
5 years ago (2015-12-03 10:28:08 UTC) #5
droger
Ok, landing this with TBR=ellyjones I'm not comfortable doing this, since the change is basically ...
5 years ago (2015-12-03 10:33:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1498793002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1498793002/20001
5 years ago (2015-12-03 10:34:10 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years ago (2015-12-03 10:42:56 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-03 10:43:39 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3e043848b6ef6fc7b2dae0a83c98db9331799dd1
Cr-Commit-Position: refs/heads/master@{#362946}

Powered by Google App Engine
This is Rietveld 408576698