chrome/browser/ui/views/frame/immersive_mode_controller_factory_views.cc - Issue 1498733003: Ash Flag on Linux: Modified and Renamed Factory Files

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/views/frame/immersive_mode_controller_factory_views.cc

Issue 1498733003: Ash Flag on Linux: Modified and Renamed Factory Files (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: factory stuff in .gypi file only now. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/views/frame/browser_non_client_frame_view_factory_views.cc ('K') | « chrome/browser/ui/views/frame/immersive_mode_controller_factory_ash.cc ('k') | chrome/chrome_browser_ui.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/ui/host_desktop.h"	5 #include "chrome/browser/ui/host_desktop.h"

6 #include "chrome/browser/ui/views/frame/immersive_mode_controller_ash.h"	6 #include "chrome/browser/ui/views/frame/immersive_mode_controller_ash.h"
	benwells 2015/12/07 05:03:23 This _ash include should also be put into a #if US This _ash include should also be put into a #if USE_ASH block, and not included in the build if ash isn't turned on. wierichs 2015/12/07 23:49:39 Done. Show quoted text On 2015/12/07 05:03:23, benwells wrote: > This _ash include should also be put into a #if USE_ASH block, and not included > in the build if ash isn't turned on. Done.
7 #include "chrome/browser/ui/views/frame/immersive_mode_controller_stub.h"	7 #include "chrome/browser/ui/views/frame/immersive_mode_controller_stub.h"

8	8

9 namespace chrome {	9 namespace chrome {

10	10

11 ImmersiveModeController* CreateImmersiveModeController(	11 ImmersiveModeController* CreateImmersiveModeController(

12 chrome::HostDesktopType host_desktop_type) {	12 chrome::HostDesktopType host_desktop_type) {

	13 #if defined(USE_ASH)

13 if (host_desktop_type == chrome::HOST_DESKTOP_TYPE_ASH)	14 if (host_desktop_type == chrome::HOST_DESKTOP_TYPE_ASH)

14 return new ImmersiveModeControllerAsh();	15 return new ImmersiveModeControllerAsh();

	16 #endif

15	17

16 return new ImmersiveModeControllerStub();	18 return new ImmersiveModeControllerStub();

17 }	19 }

18	20

19 } // namespace chrome	21 } // namespace chrome

OLD	NEW