Source/core/dom/Document.cpp - Issue 149873002: Remove superfluous isNull checks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Document.cpp

Issue 149873002: Remove superfluous isNull checks (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/Document.cpp

diff --git a/Source/core/dom/Document.cpp b/Source/core/dom/Document.cpp

index e3199112cca649bf8ae7e40a0ba871602fad2a2f..3a4bea201a8d675a4892f43c189a9ba4ea85f045 100644

--- a/Source/core/dom/Document.cpp

+++ b/Source/core/dom/Document.cpp

@@ -733,7 +733,7 @@ PassRefPtr<Element> Document::createElement(const AtomicString& localName, const

return 0;

}

- if (RuntimeEnabledFeatures::customElementsEnabled() && !typeExtension.isNull() && !typeExtension.isEmpty())

+ if (RuntimeEnabledFeatures::customElementsEnabled() && !typeExtension.isEmpty())

CustomElementRegistrationContext::setIsAttributeAndTypeExtension(element.get(), typeExtension);

return element;

@@ -760,7 +760,7 @@ PassRefPtr<Element> Document::createElementNS(const AtomicString& namespaceURI,

return 0;

}

- if (!typeExtension.isNull() && !typeExtension.isEmpty())

+ if (!typeExtension.isEmpty())

dominicc (has gone to gerrit) 2014/01/30 03:14:40 What about CustomElementConstructorBuilder.cpp/con

CustomElementRegistrationContext::setIsAttributeAndTypeExtension(element.get(), typeExtension);

return element;

« no previous file with comments | « no previous file | no next file » | no next file with comments »