Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 1498703002: Revert of Ship promise rejection events (Closed)

Created:
5 years ago by Khushal
Modified:
5 years ago
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Ship promise rejection events (patchset #2 id:20001 of https://codereview.chromium.org/1496453002/ ) Reason for revert: This is breaking SystemWebViewShellLayoutTests on Android Webview L. See crbug/564765. Original issue's description: > Ship promise rejection events > > I2S: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/AmChp_uVpXU > > BUG=495801 > R=philipj@opera.com > > Committed: https://crrev.com/98bd85306f3a170fa465c3f5a754ac2519a36be1 > Cr-Commit-Position: refs/heads/master@{#362695} TBR=philipj@opera.com,jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=495801 Committed: https://crrev.com/f3e241833fad43bec928922e949fa8cd2f4d84ff Cr-Commit-Position: refs/heads/master@{#362891}

Patch Set 1 #

Messages

Total messages: 17 (7 generated)
Khushal
Created Revert of Ship promise rejection events
5 years ago (2015-12-03 03:18:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1498703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1498703002/1
5 years ago (2015-12-03 03:19:09 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years ago (2015-12-03 03:19:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1498703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1498703002/1
5 years ago (2015-12-03 03:19:59 UTC) #7
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years ago (2015-12-03 03:20:01 UTC) #9
Ian Wen
Khushal is the sheriff today but he lacks the commiter's right to revert a CL. ...
5 years ago (2015-12-03 03:33:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1498703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1498703002/1
5 years ago (2015-12-03 03:37:42 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 03:39:32 UTC) #14
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f3e241833fad43bec928922e949fa8cd2f4d84ff Cr-Commit-Position: refs/heads/master@{#362891}
5 years ago (2015-12-03 03:40:52 UTC) #16
jochen (gone - plz use gerrit)
5 years ago (2015-12-03 07:58:11 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1495723003/ by jochen@chromium.org.

The reason for reverting is: i'll disable the test instead.

Powered by Google App Engine
This is Rietveld 408576698