Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 1498673002: GN: Make //components/nacl depend on //sandbox (Closed)

Created:
5 years ago by Roland McGrath
Modified:
5 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Make //components/nacl depend on //sandbox This is necessary to pass 'gn check' on Windows because components/nacl/loader/nacl_main_platform_delegate_win.cc uses the sandbox/win/src/sandbox.h header. The direct dependency is not strictly necessary on Mac because its implementation of NaClMainPlatformDelegate::EnableSandbox uses the wrapper interface content::InitializeSandbox, nor on Linux because the zygote handles it. But it doesn't hurt. BUG=512869 R=bradnelson@chromium.org, mseaborn@chromium.org Committed: https://crrev.com/70cb5268725c404561bc440c134448ded6aedb21 Cr-Commit-Position: refs/heads/master@{#362925}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M components/nacl/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Roland McGrath
5 years ago (2015-12-03 02:07:17 UTC) #1
Mark Seaborn
LGTM
5 years ago (2015-12-03 05:44:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1498673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1498673002/1
5 years ago (2015-12-03 06:30:57 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 07:05:24 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-03 07:06:50 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/70cb5268725c404561bc440c134448ded6aedb21
Cr-Commit-Position: refs/heads/master@{#362925}

Powered by Google App Engine
This is Rietveld 408576698