PlzNavigate: fix crash in unit_tests

PlzNavigate: fix crash in unit_tests

This Cl fixes a crash happening in 192 unit_tests with PlzNavigate enabled.

BUG=510836
Committed: https://crrev.com/f7e6422cfba09e4b34a51fa66133ffc589facc7c
Cr-Commit-Position: refs/heads/master@{#362991}

[clamy, 2015-12-03 14:35:28]

Description was changed from

==========
PlzNavigate: fix crash in unit_tests

This Cl fixes a crash happening in 192 unit_tests with PlzNavigate enabled.

BUG=510836
==========

to

==========
PlzNavigate: fix crash in unit_tests

This Cl fixes a crash happening in 192 unit_tests with PlzNavigate enabled.

BUG=510836
==========

[clamy, 2015-12-03 14:35:28]

clamy@chromium.org changed reviewers:
+ nasko@chromium.org

[clamy, 2015-12-03 14:36:01]

@nasko: PTAL (davidben is behind on reviews, hence why I'm sending this one to
you).

[nasko, 2015-12-03 15:10:27]

LGTM

https://codereview.chromium.org/1498663003/diff/1/content/browser/loader/navi...
File content/browser/loader/navigation_url_loader_impl_core.cc (right):

https://codereview.chromium.org/1498663003/diff/1/content/browser/loader/navi...
content/browser/loader/navigation_url_loader_impl_core.cc:51: if
(ResourceDispatcherHostImpl::Get()) {
Interesting. If we hit this in real code (for some reason), it means the browser
won't be able to navigate, right? I wonder if there is some way to detect
running in test environment.

[clamy, 2015-12-03 16:15:02]

Thanks!

https://codereview.chromium.org/1498663003/diff/1/content/browser/loader/navi...
File content/browser/loader/navigation_url_loader_impl_core.cc (right):

https://codereview.chromium.org/1498663003/diff/1/content/browser/loader/navi...
content/browser/loader/navigation_url_loader_impl_core.cc:51: if
(ResourceDispatcherHostImpl::Get()) {
On 2015/12/03 15:10:27, nasko wrote:
> Interesting. If we hit this in real code (for some reason), it means the
browser
> won't be able to navigate, right? I wonder if there is some way to detect
> running in test environment.

Mm not sure. It's not a change from the current situation though: if you don't
have a ResourceDispatcherHostImpl you can't handle the ResourceRequest from the
renderer.

[clamy, 2015-12-03 16:15:10]

The CQ bit was checked by clamy@chromium.org

[commit-bot: I haz the power, 2015-12-03 16:15:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1498663003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1498663003/1

[commit-bot: I haz the power, 2015-12-03 16:19:57]

Description was changed from

==========
PlzNavigate: fix crash in unit_tests

This Cl fixes a crash happening in 192 unit_tests with PlzNavigate enabled.

BUG=510836
==========

to

==========
PlzNavigate: fix crash in unit_tests

This Cl fixes a crash happening in 192 unit_tests with PlzNavigate enabled.

BUG=510836
==========

[commit-bot: I haz the power, 2015-12-03 16:19:57]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-03 16:21:02]

Description was changed from

==========
PlzNavigate: fix crash in unit_tests

This Cl fixes a crash happening in 192 unit_tests with PlzNavigate enabled.

BUG=510836
==========

to

==========
PlzNavigate: fix crash in unit_tests

This Cl fixes a crash happening in 192 unit_tests with PlzNavigate enabled.

BUG=510836

Committed: https://crrev.com/f7e6422cfba09e4b34a51fa66133ffc589facc7c
Cr-Commit-Position: refs/heads/master@{#362991}
==========

[commit-bot: I haz the power, 2015-12-03 16:21:02]

Patchset 1 (id:??) landed as
https://crrev.com/f7e6422cfba09e4b34a51fa66133ffc589facc7c
Cr-Commit-Position: refs/heads/master@{#362991}