Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1498663002: [Sync] Clear access token on shutdown (Closed)

Created:
5 years ago by Nicolas Zea
Modified:
5 years ago
Reviewers:
pavely
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, maxbogue+watch_chromium.org, plaree+watch_chromium.org, zea+watch_chromium.org, bzanotti
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Clear access token on shutdown This is a modified version of bzanotti@'s CL: https://codereview.chromium.org/1496573002/ We now clear the access token anytime the sync engine shuts down. BUG=563416 Committed: https://crrev.com/9eae1e28f5d8de8cd2a7223a97cda18975f0aa10 Cr-Commit-Position: refs/heads/master@{#362916}

Patch Set 1 #

Patch Set 2 : Disable test for CROS #

Patch Set 3 : No really #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M chrome/browser/sync/profile_sync_service_unittest.cc View 1 2 1 chunk +24 lines, -0 lines 0 comments Download
M components/browser_sync/browser/profile_sync_service.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
Nicolas Zea
+Pavel, PTAL
5 years ago (2015-12-03 00:56:10 UTC) #2
pavely
lgtm
5 years ago (2015-12-03 00:58:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1498663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1498663002/1
5 years ago (2015-12-03 01:00:11 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/96183)
5 years ago (2015-12-03 01:56:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1498663002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1498663002/20001
5 years ago (2015-12-03 03:38:47 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/96248) linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
5 years ago (2015-12-03 03:52:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1498663002/20002 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1498663002/20002
5 years ago (2015-12-03 04:40:38 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:20002)
5 years ago (2015-12-03 05:31:19 UTC) #16
commit-bot: I haz the power
5 years ago (2015-12-03 05:32:19 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9eae1e28f5d8de8cd2a7223a97cda18975f0aa10
Cr-Commit-Position: refs/heads/master@{#362916}

Powered by Google App Engine
This is Rietveld 408576698