Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1498653002: Add option to control maximum GrBatch lookback (Closed)

Created:
5 years ago by bsalomon
Modified:
5 years ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@drect
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add option to control maximum GrBatch lookback Committed: https://skia.googlesource.com/skia/+/489147c78b2091b87a80dac50a3e8f0f8eb42124

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : fix rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -13 lines) Patch
M dm/DMSrcSink.cpp View 1 2 3 1 chunk +5 lines, -9 lines 0 comments Download
M include/gpu/GrContextOptions.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 2 4 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
bsalomon
5 years ago (2015-12-03 00:22:43 UTC) #2
joshualitt
On 2015/12/03 00:22:43, bsalomon wrote: lgtm, once we have stats we should play around with ...
5 years ago (2015-12-03 14:45:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1498653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1498653002/1
5 years ago (2015-12-03 18:09:32 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/4516)
5 years ago (2015-12-03 19:13:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1498653002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1498653002/20001
5 years ago (2015-12-03 21:32:29 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Build-Mac10.8-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_TIMED_OUT, no build URL) Build-Ubuntu-Clang-x86_64-Debug-Trybot on ...
5 years ago (2015-12-03 23:33:07 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1498653002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1498653002/40001
5 years ago (2015-12-14 19:55:12 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1498653002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1498653002/60001
5 years ago (2015-12-14 19:56:01 UTC) #19
commit-bot: I haz the power
5 years ago (2015-12-14 20:13:11 UTC) #21
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/489147c78b2091b87a80dac50a3e8f0f8eb42124

Powered by Google App Engine
This is Rietveld 408576698