Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 1498643002: Minor cleanup in inferrer folder (Closed)

Created:
5 years ago by Siggi Cherem (dart-lang)
Modified:
5 years ago
Reviewers:
Johnni Winther, sra1
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Minor cleanup in inferrer folder: - divided parts into their own libraries - removed TypeMaskSystem (it was not really used except for one method) R=johnniwinther@google.com, sra@google.com Committed: https://github.com/dart-lang/sdk/commit/ffce70d0aee73ce3120b1ddfd5bc58407aa16a81

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -210 lines) Patch
M pkg/compiler/lib/src/inferrer/closure_tracer.dart View 7 chunks +33 lines, -22 lines 0 comments Download
A + pkg/compiler/lib/src/inferrer/debug.dart View 1 chunk +5 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/list_tracer.dart View 1 chunk +8 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/map_tracer.dart View 1 chunk +7 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/node_tracer.dart View 4 chunks +14 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart View 2 chunks +9 lines, -149 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart View 11 chunks +13 lines, -23 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_nodes.dart View 7 chunks +66 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Siggi Cherem (dart-lang)
It might not be worth it since we are planning to change things dramatically in ...
5 years ago (2015-12-03 00:29:55 UTC) #5
sra1
lgtm
5 years ago (2015-12-03 01:28:16 UTC) #6
Johnni Winther
lgtm
5 years ago (2015-12-03 09:07:45 UTC) #7
Siggi Cherem (dart-lang)
5 years ago (2015-12-04 21:37:11 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:40001) manually as
ffce70d0aee73ce3120b1ddfd5bc58407aa16a81 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698