tools/telemetry/telemetry/core/exceptions.py - Issue 1498633003: Added unit test for stack traces in telemetry crashes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/exceptions.py

Issue 1498633003: Added unit test for stack traces in telemetry crashes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Just enable for mac for now, focus on one platform Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/perf/core/stacktrace_unittest.py ('k') | tools/telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/exceptions.py

diff --git a/tools/telemetry/telemetry/core/exceptions.py b/tools/telemetry/telemetry/core/exceptions.py

index 96eb6fb20f41a5b1764224f992c7b3f92d9eb61b..b16efaacfd60fdf8b608080963d0303745b5307d 100644

--- a/tools/telemetry/telemetry/core/exceptions.py

+++ b/tools/telemetry/telemetry/core/exceptions.py

@@ -68,6 +68,10 @@ class AppCrashException(Error):

except Exception as err:

logging.error('Problem when trying to gather standard output: %s' % err)

+ @property

+ def stack_trace(self):

+ return self._stack_trace

def __str__(self):

divider = '*' * 80

debug_messages = []