Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Unified Diff: tools/perf/core/stacktrace_unittest.py

Issue 1498633003: Added unit test for stack traces in telemetry crashes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Search for framework file Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/exceptions.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/core/stacktrace_unittest.py
diff --git a/tools/perf/core/stacktrace_unittest.py b/tools/perf/core/stacktrace_unittest.py
new file mode 100644
index 0000000000000000000000000000000000000000..c941a4364487e9028dbeaa1b5703e921e6867278
--- /dev/null
+++ b/tools/perf/core/stacktrace_unittest.py
@@ -0,0 +1,18 @@
+# Copyright 2015 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+from telemetry.core import exceptions
+from telemetry import decorators
+from telemetry.testing import tab_test_case
+
+class TabStackTraceTest(tab_test_case.TabTestCase):
+
+ # Currently stack traces do not work on windows: http://crbug.com/476110
+ # Linux stack traces depends on fission support: http://crbug.com/405623
+ @decorators.Enabled('mac')
nednguyen 2015/12/17 02:26:54 Add: @decorators.Isolated so that this test is not
David Yen 2015/12/21 17:47:50 Hmm, I've added this now but that's a little bit w
+ def testCrashSymbols(self):
+ try:
nednguyen 2015/12/17 02:26:54 Maybe you need to clear out/Release/Chromium.app/C
David Yen 2015/12/21 17:47:50 That file is part of the executable so that should
+ self._tab.Navigate('chrome://crash', timeout=5)
+ except exceptions.DevtoolsTargetCrashException as e:
+ self.assertTrue('CrashIntentionally' in '\n'.join(e.stack_trace))
nednguyen 2015/12/17 01:52:45 self.assertIn('CrashIntentionally', '\n'.join(e.st
David Yen 2015/12/21 17:47:50 Done.
« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/exceptions.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698