Issue 149863002: Don't revoke tokens on logout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149863002: Don't revoke tokens on logout. (Closed)

Created:
6 years, 10 months ago by Jamie

Modified:
6 years, 10 months ago

Reviewers:
rmsousa

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Don't revoke tokens on logout. It's no longer possible to revoke individual tokens, which means that signing out of the web-app will cause all of user's hosts to drop off-line. This CL "fixes" this by not revoking tokens at all. Note that users can still hit the OAuth token limit, in which case hosts will start dropping off-line one at a time; this will be addressed by migrating hosts to use robot accounts. BUG=222527 R=rmsousa@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247762

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -80 lines)			Patch
M	remoting/webapp/host_controller.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/webapp/oauth2.js	View	6 chunks	+3 lines, -45 lines	0 comments	Download
M	remoting/webapp/oauth2_api.js	View	2 chunks	+0 lines, -34 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jamie

6 years, 10 months ago (2014-01-29 22:40:03 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r247762 (presubmit successful).

Expand Messages | Collapse Messages