Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Unified Diff: src/js/symbol.js

Issue 1498593006: [proxies] Use JSReceiver::GetKeys() for more purposes (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/js/prologue.js ('k') | src/js/v8natives.js » ('j') | src/objects.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/js/symbol.js
diff --git a/src/js/symbol.js b/src/js/symbol.js
index 62ef0dd2167bfc6185bde0adf0d92775a7b16464..5be6e0168d7a2d2629340264fdfcf09b3db0de3b 100644
--- a/src/js/symbol.js
+++ b/src/js/symbol.js
@@ -18,14 +18,12 @@ var isConcatSpreadableSymbol =
utils.ImportNow("is_concat_spreadable_symbol");
var iteratorSymbol = utils.ImportNow("iterator_symbol");
var MakeTypeError;
-var ObjectGetOwnPropertyKeys;
var toPrimitiveSymbol = utils.ImportNow("to_primitive_symbol");
var toStringTagSymbol = utils.ImportNow("to_string_tag_symbol");
var unscopablesSymbol = utils.ImportNow("unscopables_symbol");
utils.Import(function(from) {
MakeTypeError = from.MakeTypeError;
- ObjectGetOwnPropertyKeys = from.ObjectGetOwnPropertyKeys;
});
// -------------------------------------------------------------------
@@ -80,9 +78,7 @@ function SymbolKeyFor(symbol) {
function ObjectGetOwnPropertySymbols(obj) {
obj = TO_OBJECT(obj);
- // TODO(arv): Proxies use a shared trap for String and Symbol keys.
-
- return ObjectGetOwnPropertyKeys(obj, PROPERTY_ATTRIBUTES_STRING);
+ return %GetOwnPropertyKeys(obj, PROPERTY_FILTER_SKIP_STRINGS);
}
// -------------------------------------------------------------------
« no previous file with comments | « src/js/prologue.js ('k') | src/js/v8natives.js » ('j') | src/objects.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698