Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issue 1498583002: Revert of skstd -> std for unique_ptr (Closed)

Created:
5 years ago by mtklein
Modified:
5 years ago
CC:
reviews_skia.org, stephana
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of skstd -> std for unique_ptr (patchset #17 id:320001 of https://codereview.chromium.org/1436033003/ ) Reason for revert: Chromium bots can't handle forward declared types, e.g. struct Foo { int x,y; std::unique_ptr<Foo> next; }; https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/86497 Original issue's description: > skstd -> std for unique_ptr > > TBR=reed@google.com > No public API changes. > > BUG=skia:4564 > > Committed: https://skia.googlesource.com/skia/+/755c553c17b82bb5de3d9cc8d3b2a866ff9e9e50 > > CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot,Build-Ubuntu-GCC-x86_64-Debug-CrOS_Link-Trybot;client.skia:Perf-Mac10.9-Clang-MacMini6.2-CPU-AVX-x86_64-Release-Trybot,Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Release-Trybot > > Committed: https://skia.googlesource.com/skia/+/06189155d987db5c7e69015f6ea87c2168d6a065 > > Committed: https://skia.googlesource.com/skia/+/70e8dfca4a7f5bce97b8021a6e378c4828b09c8c > > Committed: https://skia.googlesource.com/skia/+/dadfc245cc9a0279ff7b73da3344f2ca5d139907 TBR=bungeman@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4564 Committed: https://skia.googlesource.com/skia/+/5c05d10511610c35f7912d48ede509c7e32e0a3c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+493 lines, -33 lines) Patch
M gyp/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkRefCnt.h View 2 chunks +4 lines, -7 lines 0 comments Download
M include/core/SkTypes.h View 1 chunk +1 line, -5 lines 0 comments Download
M include/private/SkOncePtr.h View 3 chunks +3 lines, -3 lines 0 comments Download
M include/private/SkTemplates.h View 4 chunks +13 lines, -13 lines 0 comments Download
A include/private/SkUniquePtr.h View 1 chunk +396 lines, -0 lines 0 comments Download
M src/android/SkBitmapRegionDecoder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkSharedMutex.h View 2 chunks +4 lines, -4 lines 0 comments Download
M tests/CPlusPlusEleven.cpp View 1 chunk +69 lines, -0 lines 0 comments Download
M tools/BUILD.public.expected View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
mtklein
Created Revert of skstd -> std for unique_ptr
5 years ago (2015-12-02 20:31:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1498583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1498583002/1
5 years ago (2015-12-02 20:31:23 UTC) #2
commit-bot: I haz the power
5 years ago (2015-12-02 20:32:05 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/5c05d10511610c35f7912d48ede509c7e32e0a3c

Powered by Google App Engine
This is Rietveld 408576698