Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2069)

Unified Diff: pkg/analyzer/lib/src/generated/engine.dart

Issue 1498573002: Hide inference hints. Fixes #24563. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Move TODO Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/context/context.dart ('k') | pkg/analyzer/lib/src/generated/resolver.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/generated/engine.dart
diff --git a/pkg/analyzer/lib/src/generated/engine.dart b/pkg/analyzer/lib/src/generated/engine.dart
index 9be1f2d74a84f381e3e4dd6fe0982854fd0ea449..fbb9825418861684827ebc24001998cf160c6323 100644
--- a/pkg/analyzer/lib/src/generated/engine.dart
+++ b/pkg/analyzer/lib/src/generated/engine.dart
@@ -1170,6 +1170,9 @@ class AnalysisContextImpl implements InternalAnalysisContext {
(this._options.hint && !options.hint) ||
this._options.preserveComments != options.preserveComments ||
this._options.strongMode != options.strongMode ||
+ ((options is AnalysisOptionsImpl)
+ ? this._options.strongModeHints != options.strongModeHints
+ : false) ||
this._options.enableStrictCallChecks !=
options.enableStrictCallChecks ||
this._options.enableSuperMixins != options.enableSuperMixins;
@@ -1206,6 +1209,9 @@ class AnalysisContextImpl implements InternalAnalysisContext {
this._options.lint = options.lint;
this._options.preserveComments = options.preserveComments;
this._options.strongMode = options.strongMode;
+ if (options is AnalysisOptionsImpl) {
+ this._options.strongModeHints = options.strongModeHints;
+ }
_generateImplicitErrors = options.generateImplicitErrors;
_generateSdkErrors = options.generateSdkErrors;
if (needsRecompute) {
@@ -6462,6 +6468,14 @@ class AnalysisOptionsImpl implements AnalysisOptions {
bool strongMode = false;
/**
+ * A flag indicating whether strong-mode inference hints should be
+ * used. This flag is not exposed in the interface, and should be
+ * replaced by something more general.
+ */
+ // TODO(leafp): replace this with something more general
+ bool strongModeHints = false;
+
+ /**
* Initialize a newly created set of analysis options to have their default
* values.
*/
@@ -6488,6 +6502,9 @@ class AnalysisOptionsImpl implements AnalysisOptions {
lint = options.lint;
preserveComments = options.preserveComments;
strongMode = options.strongMode;
+ if (options is AnalysisOptionsImpl) {
+ strongModeHints = options.strongModeHints;
+ }
}
/**
@@ -6510,6 +6527,9 @@ class AnalysisOptionsImpl implements AnalysisOptions {
lint = options.lint;
preserveComments = options.preserveComments;
strongMode = options.strongMode;
+ if (options is AnalysisOptionsImpl) {
+ strongModeHints = options.strongModeHints;
+ }
}
bool get analyzeFunctionBodies {
« no previous file with comments | « pkg/analyzer/lib/src/context/context.dart ('k') | pkg/analyzer/lib/src/generated/resolver.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698