Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 1498573002: Hide inference hints. Fixes #24563. (Closed)

Created:
5 years ago by Leaf
Modified:
5 years ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org, Brian Wilkerson
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Move TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -24 lines) Patch
M pkg/analyzer/lib/src/context/context.dart View 2 chunks +6 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 1 5 chunks +20 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 4 chunks +15 lines, -5 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 3 chunks +31 lines, -19 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/strong_test_helper.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Leaf
This re-hides the inference hints except while we're running the strong mode tests. I'm not ...
5 years ago (2015-12-02 20:30:12 UTC) #2
Jennifer Messerly
Not sure if there's precedent for putting an option only on *Impl, but LGTM. https://codereview.chromium.org/1498573002/diff/1/pkg/analyzer/lib/src/generated/engine.dart ...
5 years ago (2015-12-02 20:37:18 UTC) #3
Leaf
https://codereview.chromium.org/1498573002/diff/1/pkg/analyzer/lib/src/generated/engine.dart File pkg/analyzer/lib/src/generated/engine.dart (right): https://codereview.chromium.org/1498573002/diff/1/pkg/analyzer/lib/src/generated/engine.dart#newcode6474 pkg/analyzer/lib/src/generated/engine.dart:6474: * TODO(leafp): replace this with something more general On ...
5 years ago (2015-12-02 21:07:38 UTC) #4
Leaf
5 years ago (2015-12-02 21:07:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
daf5f6d258a99428cc4dc9ff17645a33e4e4bebd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698