Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1498553002:
Cleanup <image> type handling (Closed)
|
Created:
5 years ago by rwlbuis Modified:
5 years ago Reviewers:
Timothy Loh CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionCleanup <image> type handling
Cleanup <image> type handling in two ways:
- to handle list-style-image, border-image-source and
webkit-mask-box-image-source simply reuse parseFillImage.
- to make isGeneratedImageValue more reusable use a CSSValueID parameter.
BUG=499780
Committed: https://crrev.com/862237de538a943337b78e8503770847e06596bb
Cr-Commit-Position: refs/heads/master@{#362917}
Patch Set 1 #
Messages
Total messages: 16 (9 generated)
Description was changed from ========== fill-image cleanup BUG= ========== to ========== Cleanup <image> type handling Cleanup <image> type handling in two ways: - to handle list-style-image, border-image-source and webkit-maskbox-image-source simply reuse parseFillImage. - to make isGeneratedImageValue more reusable use a CSSValueID parameter. BUG=499780 ==========
Description was changed from ========== Cleanup <image> type handling Cleanup <image> type handling in two ways: - to handle list-style-image, border-image-source and webkit-maskbox-image-source simply reuse parseFillImage. - to make isGeneratedImageValue more reusable use a CSSValueID parameter. BUG=499780 ========== to ========== Cleanup <image> type handling Cleanup <image> type handling in two ways: - to handle list-style-image, border-image-source and webkit-maskbox-image-source simply reuse parseFillImage. - to make isGeneratedImageValue more reusable use a CSSValueID parameter. BUG=499780 ==========
Description was changed from ========== Cleanup <image> type handling Cleanup <image> type handling in two ways: - to handle list-style-image, border-image-source and webkit-maskbox-image-source simply reuse parseFillImage. - to make isGeneratedImageValue more reusable use a CSSValueID parameter. BUG=499780 ========== to ========== Cleanup <image> type handling Cleanup <image> type handling in two ways: - to handle list-style-image, border-image-source and webkit-mask-box-image-source simply reuse parseFillImage. - to make isGeneratedImageValue more reusable use a CSSValueID parameter. BUG=499780 ==========
rob.buis@samsung.com changed reviewers: + timloh@chromium.org
PTAL.
On 2015/12/02 23:30:30, rwlbuis wrote: > PTAL. lgtm
The CQ bit was checked by rob.buis@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1498553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1498553002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by rob.buis@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1498553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1498553002/1
Message was sent while issue was closed.
Description was changed from ========== Cleanup <image> type handling Cleanup <image> type handling in two ways: - to handle list-style-image, border-image-source and webkit-mask-box-image-source simply reuse parseFillImage. - to make isGeneratedImageValue more reusable use a CSSValueID parameter. BUG=499780 ========== to ========== Cleanup <image> type handling Cleanup <image> type handling in two ways: - to handle list-style-image, border-image-source and webkit-mask-box-image-source simply reuse parseFillImage. - to make isGeneratedImageValue more reusable use a CSSValueID parameter. BUG=499780 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Cleanup <image> type handling Cleanup <image> type handling in two ways: - to handle list-style-image, border-image-source and webkit-mask-box-image-source simply reuse parseFillImage. - to make isGeneratedImageValue more reusable use a CSSValueID parameter. BUG=499780 ========== to ========== Cleanup <image> type handling Cleanup <image> type handling in two ways: - to handle list-style-image, border-image-source and webkit-mask-box-image-source simply reuse parseFillImage. - to make isGeneratedImageValue more reusable use a CSSValueID parameter. BUG=499780 Committed: https://crrev.com/862237de538a943337b78e8503770847e06596bb Cr-Commit-Position: refs/heads/master@{#362917} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/862237de538a943337b78e8503770847e06596bb Cr-Commit-Position: refs/heads/master@{#362917} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
