Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 1498523008: Revert of [debugger] do not predict step in target for liveedit. (Closed)

Created:
5 years ago by Michael Achenbach
Modified:
5 years ago
Reviewers:
Toon Verwaest, Yang
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@liveeditstep
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [debugger] do not predict step in target for liveedit. (patchset #2 id:20001 of https://codereview.chromium.org/1491743005/ ) Reason for revert: [Sheriff] And it still breaks: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/3239 Please run chromium trybots on relands of CLs that broke chromium bots. Original issue's description: > [debugger] do not predict step in target for liveedit. > > R=verwaest@chromium.org > > Committed: https://crrev.com/8f87ff5d62e996b07ffbde7e735daa603c1d7290 > Cr-Commit-Position: refs/heads/master@{#32553} > > Committed: https://crrev.com/00559c4584fe3a4c3c1a8d3a5b5af0611b19c40a > Cr-Commit-Position: refs/heads/master@{#32600} TBR=verwaest@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/6f4d477f32f98ae46bf88e662eb05a99fddc9939 Cr-Commit-Position: refs/heads/master@{#32607}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -55 lines) Patch
M src/arm/macro-assembler-arm.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/assembler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/assembler.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/builtins.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/builtins.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/debug/arm/debug-arm.cc View 2 chunks +12 lines, -3 lines 0 comments Download
M src/debug/arm64/debug-arm64.cc View 1 chunk +14 lines, -6 lines 0 comments Download
M src/debug/debug.h View 4 chunks +14 lines, -1 line 0 comments Download
M src/debug/debug.cc View 3 chunks +16 lines, -1 line 0 comments Download
M src/debug/ia32/debug-ia32.cc View 1 chunk +10 lines, -3 lines 0 comments Download
M src/debug/liveedit.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/debug/liveedit.cc View 8 chunks +33 lines, -10 lines 0 comments Download
M src/debug/mips/debug-mips.cc View 1 chunk +11 lines, -3 lines 0 comments Download
M src/debug/mips64/debug-mips64.cc View 1 chunk +11 lines, -3 lines 0 comments Download
M src/debug/x64/debug-x64.cc View 1 chunk +11 lines, -3 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/snapshot/serialize.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of [debugger] do not predict step in target for liveedit.
5 years ago (2015-12-04 10:42:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1498523008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1498523008/1
5 years ago (2015-12-04 10:42:48 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-04 10:43:08 UTC) #4
commit-bot: I haz the power
5 years ago (2015-12-04 10:43:39 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6f4d477f32f98ae46bf88e662eb05a99fddc9939
Cr-Commit-Position: refs/heads/master@{#32607}

Powered by Google App Engine
This is Rietveld 408576698