Extract Local refactoring: skip method names in invocations.

pkg/analysis_server/test/services/refactoring/extract_local_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.services.refactoring.extract_local;
 
 import 'dart:async';
 
 import 'package:analysis_server/plugin/protocol/protocol.dart';
 import 'package:analysis_server/src/services/correction/status.dart';
@@ skipping 51 matching lines @@
   v = 1;
 }
 ''');
     _createRefactoringWithSuffix('v', ' = 1;');
     // check conditions
     RefactoringStatus status = await refactoring.checkAllConditions();
     assertRefactoringStatus(status, RefactoringProblemSeverity.FATAL,
         expectedMessage: 'Cannot extract the left-hand side of an assignment.');
   }
 
-  test_checkInitialConditions_methodName_reference() async {
+  test_checkInitialConditions_namePartOfDeclaration_function() async {
     indexTestUnit('''
 main() {
-  main();
 }
 ''');
-    _createRefactoringWithSuffix('main', '();');
+    _createRefactoringWithSuffix('main', '()');
     // check conditions
     RefactoringStatus status = await refactoring.checkAllConditions();
     assertRefactoringStatus(status, RefactoringProblemSeverity.FATAL,
-        expectedMessage: 'Cannot extract a single method name.');
+        expectedMessage: 'Cannot extract the name part of a declaration.');
   }
 
   test_checkInitialConditions_namePartOfDeclaration_variable() async {
     indexTestUnit('''
 main() {
   int vvv = 0;
 }
 ''');
     _createRefactoringWithSuffix('vvv', ' = 0;');
     // check conditions
@@ skipping 759 matching lines @@
     _createRefactoringForString('1 /*abc*/');
     // apply refactoring
     return _assertSuccessfulRefactoring('''
 main() {
   var res = 1 /*abc*/ + 2;
   int a = res + 345;
 }
 ''');
   }
 
+  test_singleExpression_methodName_reference() async {
+    indexTestUnit('''
+main() {
+  var v = foo().length;
+}
+String foo() => '';
+''');
+    _createRefactoringWithSuffix('foo', '().');
+    // apply refactoring
+    return _assertSuccessfulRefactoring('''
+main() {
+  var res = foo();
+  var v = res.length;
+}
+String foo() => '';
+''');
+  }
+
   test_singleExpression_nameOfProperty_prefixedIdentifier() async {
     indexTestUnit('''
 main(p) {
   var v = p.value; // marker
 }
 ''');
     _createRefactoringWithSuffix('value', '; // marker');
     // apply refactoring
     return _assertSuccessfulRefactoring('''
 main(p) {
@@ skipping 15 matching lines @@
     return _assertSuccessfulRefactoring('''
 main() {
   var res = foo().length;
   var v = res; // marker
 }
 String foo() => '';
 ''');
   }
 
   /**
-   * Here we use knowledge how exactly `1 + 2 + 3 + 41 is parsed. We know that
+   * Here we use knowledge how exactly `1 + 2 + 3 + 4` is parsed. We know that
    * `1 + 2` will be a separate and complete binary expression, so it can be
    * handled as a single expression.
    */
   test_singleExpression_partOfBinaryExpression() {
     indexTestUnit('''
 main() {
   int a = 1 + 2 + 3 + 4;
 }
 ''');
     _createRefactoringForString('1 + 2');
@@ skipping 122 matching lines @@
     int length = search.length;
     _createRefactoring(offset, length);
   }
 
   void _createRefactoringWithSuffix(String selectionSearch, String suffix) {
     int offset = findOffset(selectionSearch + suffix);
     int length = selectionSearch.length;
     _createRefactoring(offset, length);
   }
 }