Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1498523002: drawSprite and drawImage+clip (Closed)

Created:
5 years ago by reed1
Modified:
5 years ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

drawSprite and drawImage+clip should draw the same w/ an imagefilter applied. This gm exercises that invariant. BUG=skia: Committed: https://skia.googlesource.com/skia/+/0711bdbccae72aa011ad5a5cb63284e912bb6f7b

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -0 lines) Patch
M gm/spritebitmap.cpp View 1 2 3 4 1 chunk +122 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
reed1
5 years ago (2015-12-02 18:59:44 UTC) #2
robertphillips
lgtm + name suggestion https://codereview.chromium.org/1498523002/diff/60001/gm/spritebitmap.cpp File gm/spritebitmap.cpp (right): https://codereview.chromium.org/1498523002/diff/60001/gm/spritebitmap.cpp#newcode230 gm/spritebitmap.cpp:230: Maybe make_red_oval_image ?
5 years ago (2015-12-02 20:37:06 UTC) #5
reed1
https://codereview.chromium.org/1498523002/diff/60001/gm/spritebitmap.cpp File gm/spritebitmap.cpp (right): https://codereview.chromium.org/1498523002/diff/60001/gm/spritebitmap.cpp#newcode230 gm/spritebitmap.cpp:230: On 2015/12/02 20:37:06, robertphillips wrote: > Maybe make_red_oval_image ? ...
5 years ago (2015-12-02 20:39:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1498523002/20002 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1498523002/20002
5 years ago (2015-12-02 20:39:45 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-02 20:58:41 UTC) #11
Message was sent while issue was closed.
Committed patchset #5 (id:20002) as
https://skia.googlesource.com/skia/+/0711bdbccae72aa011ad5a5cb63284e912bb6f7b

Powered by Google App Engine
This is Rietveld 408576698