pkg/serialization - more types

pkg/serialization/lib/src/serialization_rule.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of serialization;
 
 // TODO(alanknight): We should have an example and tests for subclassing
 // serialization rule rather than using the hard-coded ClosureToMap rule. And
 // possibly an abstract superclass that's designed to be subclassed that way.
 /**
@@ skipping 120 matching lines @@
    */
   int get dataLength => 0;
 }
 
 /**
  * This rule handles things that implement List. It will recreate them as
  * whatever the default implemenation of List is on the target platform.
  */
 class ListRule extends SerializationRule {
 
-  appliesTo(object, Writer w) => object is List;
+  bool appliesTo(object, Writer w) => object is List;
 
   bool get storesStateAsLists => true;
 
   List extractState(List list, f, Writer w) {
     var result = new List();
     for (var each in list) {
       result.add(each);
       f(each);
     }
     return result;
@@ skipping 37 matching lines @@
 }
 
 /**
  * This rule handles things that implement Map. It will recreate them as
  * whatever the default implemenation of Map is on the target platform. If a
  * map has string keys it will attempt to retain it as a map for JSON formats,
  * otherwise it will store it as a list of references to keys and values.
  */
 class MapRule extends SerializationRule {
 
-  appliesTo(object, Writer w) => object is Map;
+  bool appliesTo(object, Writer w) => object is Map;
 
   bool get storesStateAsMaps => true;
 
   extractState(Map map, f, Writer w) {
     // Note that we make a copy here because flattening may be destructive.
     var newMap = new Map.from(map);
     newMap.forEach((key, value) {
       f(key);
       f(value);
     });
@@ skipping 55 matching lines @@
 
   bool get hasVariableLengthEntries => true;
 }
 
 /**
  * This rule handles primitive types, defined as those that we can normally
  * represent directly in the output format. We hard-code that to mean
  * num, String, and bool.
  */
 class PrimitiveRule extends SerializationRule {
-  appliesTo(object, Writer w) {
-    return isPrimitive(object);
-  }
+  bool appliesTo(object, Writer w) => isPrimitive(object);
   extractState(object, Function f, Writer w) => object;
   flatten(object, Writer writer) {}
   inflateEssential(state, Reader r) => state;
   inflateNonEssential(object, _, Reader r) {}
 
   bool get storesStateAsPrimitives => true;
 
   /**
    * Indicate whether we should save pointers to this object as references
    * or store the object directly. For primitives this depends on the format,
@@ skipping 39 matching lines @@
    */
   ClosureRule(this.type, this.getStateFunction, this.construct,
       this.setNonEssentialState);
 
   bool appliesTo(object, Writer w) => object.runtimeType == type;
 
   getState(object) => getStateFunction(object);
 
   create(state) => construct(state);
 
-  setState(object, state) {
+  void setState(object, state) {
     if (setNonEssentialState == null) return;
     setNonEssentialState(object, state);
   }
 }
 
 /**
  * This rule handles things we can't pass directly, but only by reference.
  * If objects are listed in the namedObjects in the writer or serialization,
  * it will save the name rather than saving the state.
  */
@@ skipping 24 matching lines @@
   }
 
   /** Look up the named object and return it. */
   inflateEssential(state, Reader r) =>
       r.objectNamed(r.resolveReference(state.first));
 
   /** Set any non-essential state on the object. For this rule, a no-op. */
   inflateNonEssential(state, object, Reader r) {}
 
   /** Return the name for this object in the Writer. */
-  nameFor(object, Writer writer) => writer.nameFor(object);
+  String nameFor(object, Writer writer) => writer.nameFor(object);
 }
 
 /**
  * This rule handles the special case of Mirrors. It stores the mirror by its
  * qualifiedName and attempts to look it up in both the namedObjects
  * collection, or if it's not found there, by looking it up in the mirror
  * system. When reading, the user is responsible for supplying the appropriate
  * values in [Serialization.namedObjects] or in the [externals] paramter to
  * [Serialization.read].
  */
 class MirrorRule extends NamedObjectRule {
   bool appliesTo(object, Writer writer) => object is DeclarationMirror;
-  nameFor(DeclarationMirror object, Writer writer) =>
+
+  String nameFor(DeclarationMirror object, Writer writer) =>
       MirrorSystem.getName(object.qualifiedName);
 
   inflateEssential(state, Reader r) {
     var qualifiedName = r.resolveReference(state.first);
     var lookupFull = r.objectNamed(qualifiedName, (x) => null);
     if (lookupFull != null) return lookupFull;
     var separatorIndex = qualifiedName.lastIndexOf(".");
     var type = qualifiedName.substring(separatorIndex + 1);
     var lookup = r.objectNamed(type, (x) => null);
     if (lookup != null) return lookup;
@@ skipping 67 matching lines @@
 
   inflateEssential(state, Reader r) => create(_lazy(state, r));
 
   void inflateNonEssential(state, object, Reader r) {
     setState(object, _lazy(state, r));
   }
 
   // We don't want to have to make the end user tell us how long the list is
   // separately, so write it out for each object, even though they're all
   // expected to be the same length.
-  get hasVariableLengthEntries => true;
+  bool get hasVariableLengthEntries => true;
 }
 
 /** A hard-coded rule for serializing Symbols. */
 class SymbolRule extends CustomRule {
   bool appliesTo(instance, _) => instance is Symbol;
   getState(instance) => [MirrorSystem.getName(instance)];
   create(state) => new Symbol(state[0]);
-  setState(symbol, state) {}
+  void setState(symbol, state) {}
   int get dataLength => 1;
   bool get hasVariableLengthEntries => false;
 }
 
 /** Create a lazy list/map that will inflate its items on demand in [r]. */
 _lazy(l, Reader r) {
   if (l is List) return new _LazyList(l, r);
   if (l is Map) return new _LazyMap(l, r);
   throw new SerializationException("Invalid type: must be Map or List - $l");
 }
@@ skipping 88 matching lines @@
   removeWhere(x) => _throw();
   retainWhere(x) => _throw();
   replaceRange(x, y, z) => _throw();
   getRange(x, y) => _throw();
   setRange(x, y, z, [a = 0]) => _throw();
   setAll(x, y) => _throw();
   removeRange(x, y) => _throw();
   get reversed => _throw();
   void set length(x) => _throw();
 }