content/common/view_messages.h - Issue 14985014: Introduce content::PageState

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/view_messages.h

Issue 14985014: Introduce content::PageState (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add comments to the top of page_state.h Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/browser_commands.cc ('K') | « content/browser/web_contents/web_contents_impl_unittest.cc ('k') | content/content_common.gypi » ('j') | content/public/common/page_state.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/view_messages.h

diff --git a/content/common/view_messages.h b/content/common/view_messages.h

index 250fe371abaebbd8ad777f5b4738219c70c5aa1c..e13ff187b014ac27c3f884d28320b756550acefc 100644

--- a/content/common/view_messages.h

+++ b/content/common/view_messages.h

@@ -22,6 +22,7 @@

#include "content/public/common/file_chooser_params.h"

#include "content/public/common/frame_navigate_params.h"

#include "content/public/common/javascript_message_type.h"

+#include "content/public/common/page_state.h"

#include "content/public/common/page_zoom.h"

#include "content/public/common/referrer.h"

#include "content/public/common/renderer_preferences.h"

@@ -162,7 +163,7 @@ IPC_STRUCT_TRAITS_BEGIN(content::ContextMenuParams)

IPC_STRUCT_TRAITS_MEMBER(page_url)

IPC_STRUCT_TRAITS_MEMBER(keyword_url)

IPC_STRUCT_TRAITS_MEMBER(frame_url)

- IPC_STRUCT_TRAITS_MEMBER(frame_content_state)

+ IPC_STRUCT_TRAITS_MEMBER(frame_page_state)

IPC_STRUCT_TRAITS_MEMBER(media_flags)

IPC_STRUCT_TRAITS_MEMBER(selection_text)

IPC_STRUCT_TRAITS_MEMBER(misspelled_word)

@@ -416,7 +417,7 @@ IPC_STRUCT_BEGIN_WITH_PARENT(ViewHostMsg_FrameNavigate_Params,

IPC_STRUCT_MEMBER(bool, was_fetched_via_proxy)

// Serialized history item state to store in the navigation entry.

- IPC_STRUCT_MEMBER(std::string, content_state)

+ IPC_STRUCT_MEMBER(content::PageState, page_state)

// Original request's URL.

IPC_STRUCT_MEMBER(GURL, original_request_url)

@@ -602,7 +603,7 @@ IPC_STRUCT_BEGIN(ViewMsg_Navigate_Params)

IPC_STRUCT_MEMBER(content::PageTransition, transition)

// Opaque history state (received by ViewHostMsg_UpdateState).

- IPC_STRUCT_MEMBER(std::string, state)

+ IPC_STRUCT_MEMBER(content::PageState, page_state)

// Type of navigation.

IPC_STRUCT_MEMBER(ViewMsg_Navigate_Type::Value, navigation_type)

@@ -1490,7 +1491,7 @@ IPC_MESSAGE_ROUTED4(ViewHostMsg_MediaNotification,

// page_id: unique ID that allows us to distinguish between history entries.

IPC_MESSAGE_ROUTED2(ViewHostMsg_UpdateState,

int32 /* page_id */,

- std::string /* state */)

+ content::PageState /* state */)

// Notifies the browser that a document has been loaded in a frame.

IPC_MESSAGE_ROUTED1(ViewHostMsg_DocumentLoadedInFrame,