content/browser/web_contents/navigation_entry_impl_unittest.cc - Issue 14985014: Introduce content::PageState

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/navigation_entry_impl_unittest.cc

Issue 14985014: Introduce content::PageState (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add comments to the top of page_state.h Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/navigation_entry_impl_unittest.cc

diff --git a/content/browser/web_contents/navigation_entry_impl_unittest.cc b/content/browser/web_contents/navigation_entry_impl_unittest.cc

index 8bc5de11ed23870cefdf826348486963c1de3012..4b18aaad6eb6cccc89f2fc4014378e93f1042752 100644

--- a/content/browser/web_contents/navigation_entry_impl_unittest.cc

+++ b/content/browser/web_contents/navigation_entry_impl_unittest.cc

@@ -142,10 +142,10 @@ TEST_F(NavigationEntryTest, NavigationEntryAccessors) {

EXPECT_EQ(ASCIIToUTF16("title2"), entry2_->GetTitle());

// State

- EXPECT_EQ(std::string(), entry1_->GetContentState());

- EXPECT_EQ(std::string(), entry2_->GetContentState());

- entry2_->SetContentState("state");

- EXPECT_EQ("state", entry2_->GetContentState());

+ EXPECT_FALSE(entry1_->GetPageState().IsValid());

+ EXPECT_FALSE(entry2_->GetPageState().IsValid());

+ entry2_->SetPageState(PageState::CreateFromEncodedData("state"));

+ EXPECT_EQ("state", entry2_->GetPageState().ToEncodedData());

// Page ID

EXPECT_EQ(-1, entry1_->GetPageID());