Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: third_party/WebKit/Source/core/css/DOMWindowCSS.cpp

Issue 1498473004: CSS.escape('\0') should not throw. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adding idl file changes Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/css/DOMWindowCSS.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/DOMWindowCSS.cpp
diff --git a/third_party/WebKit/Source/core/css/DOMWindowCSS.cpp b/third_party/WebKit/Source/core/css/DOMWindowCSS.cpp
index be978a78da607d5f9c5d5224770c012730a6605a..8b05f6d030cb63e8588762b3b9329117c23a55be 100644
--- a/third_party/WebKit/Source/core/css/DOMWindowCSS.cpp
+++ b/third_party/WebKit/Source/core/css/DOMWindowCSS.cpp
@@ -30,12 +30,10 @@
#include "config.h"
#include "core/css/DOMWindowCSS.h"
-#include "bindings/core/v8/ExceptionState.h"
#include "core/css/CSSMarkup.h"
#include "core/css/CSSPropertyMetadata.h"
#include "core/css/StylePropertySet.h"
#include "core/css/parser/CSSParser.h"
-#include "core/dom/ExceptionCode.h"
#include "wtf/text/StringBuilder.h"
#include "wtf/text/WTFString.h"
@@ -58,13 +56,10 @@ bool DOMWindowCSS::supports(const String& conditionText)
return CSSParser::parseSupportsCondition(conditionText);
}
-String DOMWindowCSS::escape(const String& ident, ExceptionState& exceptionState)
+String DOMWindowCSS::escape(const String& ident)
{
StringBuilder builder;
- if (!serializeIdentifier(ident, builder)) {
- exceptionState.throwDOMException(InvalidCharacterError, "The string contains an invalid character.");
- return String();
- }
+ serializeIdentifier(ident, builder);
return builder.toString();
}
« no previous file with comments | « third_party/WebKit/Source/core/css/DOMWindowCSS.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698