Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: components/omnibox/browser/omnibox_field_trial.h

Issue 1498473003: Omnibox: Add Field Trial to Skip HistoryURL Provider Searching its Database (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: expand if clause Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/omnibox/browser/omnibox_field_trial.h
diff --git a/components/omnibox/browser/omnibox_field_trial.h b/components/omnibox/browser/omnibox_field_trial.h
index 674170f0a5fb23c42241a36de174b20507a28cbe..21258a6e89b23a4284e82951c1ea9c4adf75cc36 100644
--- a/components/omnibox/browser/omnibox_field_trial.h
+++ b/components/omnibox/browser/omnibox_field_trial.h
@@ -299,8 +299,8 @@ class OmniboxFieldTrial {
static size_t HQPNumTitleWordsToAllow();
// ---------------------------------------------------------
- // For the HQPAlsoDoHUPLikeScoring experiment that's part of the
- // bundled omnibox field trial.
+ // For the replace HUP experiment that's part of the bundled omnibox field
+ // trial.
// Returns whether HistoryQuick provider (HQP) should attempt to score
// suggestions also with a HistoryURL-provider-like (HUP-like) mode, and
@@ -308,6 +308,12 @@ class OmniboxFieldTrial {
// Returns false if the experiment isn't active.
static bool HQPAlsoDoHUPLikeScoring();
+ // Returns whether HistoryURL provider (HUP) should search its database for
+ // URLs and suggest them. If false, HistoryURL provider merely creates the
+ // URL-what-you-typed match when appropriate. Return true if the experiment
+ // isn't active.
+ static bool HUPSearchDatabase();
+
// ---------------------------------------------------------
// For the PreventUWYTDefaultForNonURLInputs experiment that's part of the
// bundled omnibox field trial.
@@ -362,6 +368,7 @@ class OmniboxFieldTrial {
static const char kHQPFixFrequencyScoringBugsRule[];
static const char kHQPNumTitleWordsRule[];
static const char kHQPAlsoDoHUPLikeScoringRule[];
+ static const char kHUPSearchDatabaseRule[];
static const char kPreventUWYTDefaultForNonURLInputsRule[];
static const char kKeywordRequiresRegistryRule[];
static const char kKeywordRequiresPrefixMatchRule[];
« no previous file with comments | « components/omnibox/browser/history_url_provider.cc ('k') | components/omnibox/browser/omnibox_field_trial.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698