chrome/browser/ui/webui/chromeos/login/app_launch_splash_screen_handler.cc - Issue 149843004: kiosk: Skip network check for offline enabled app.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/chromeos/login/app_launch_splash_screen_handler.cc

Issue 149843004: kiosk: Skip network check for offline enabled app. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: add test Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/login/kiosk_browsertest.cc ('K') | « chrome/browser/ui/webui/chromeos/login/app_launch_splash_screen_handler.h ('k') | chrome/test/data/chromeos/app_mode/offline_enabled_app_profile/Extensions/ajoggoflpgplnnjkjamcmbepjdjdnpdp/1.0.0_0/app_main.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/chromeos/login/app_launch_splash_screen_handler.cc

diff --git a/chrome/browser/ui/webui/chromeos/login/app_launch_splash_screen_handler.cc b/chrome/browser/ui/webui/chromeos/login/app_launch_splash_screen_handler.cc

index aaf1913cda3da398eff5c63ae31d07b80ed9982a..1068d19f9cf271d3999093da0fd071e903b0a344 100644

--- a/chrome/browser/ui/webui/chromeos/login/app_launch_splash_screen_handler.cc

+++ b/chrome/browser/ui/webui/chromeos/login/app_launch_splash_screen_handler.cc

@@ -178,6 +178,10 @@ void AppLaunchSplashScreenHandler::ShowNetworkConfigureUI() {

error_screen_actor_->Show(OobeDisplay::SCREEN_APP_LAUNCH_SPLASH, NULL);

}

+bool AppLaunchSplashScreenHandler::IsNetworkReady() {

+ return network_state_informer_->state() == NetworkStateInformer::ONLINE;

void AppLaunchSplashScreenHandler::OnNetworkReady() {

// Purposely leave blank because the online case is handled in UpdateState

// call below.