Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1498323002:
Remove updateLayoutTreeIfNeeded from SVGElement::invalidateInstances (Closed)
|
Created:
5 years ago by pdr. Modified:
5 years ago Reviewers:
fs CC:
fs, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove updateLayoutTreeIfNeeded from SVGElement::invalidateInstances
There is no need to update the layout tree when instances are
invalidated. This fixes an O(n^2) performance bug when updating
<use> trees.
BUG=565120
Committed: https://crrev.com/491876565010e0d7d4a036460188a66c2b34c946
Cr-Commit-Position: refs/heads/master@{#363393}
Patch Set 1 #
Messages
Total messages: 22 (10 generated)
pdr@chromium.org changed reviewers: + fs@opera.com
The CQ bit was checked by pdr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1498323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1498323002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL) win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL) win_chromium_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL) win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by pdr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1498323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1498323002/1
Description was changed from ========== Remove updateLayoutTreeIfNeeded from SVGElement::invalidateInstances There is no need to update the layout tree when instances are invalidated. Found while investigating http://crbug.com/565117. ========== to ========== Remove updateLayoutTreeIfNeeded from SVGElement::invalidateInstances There is no need to update the layout tree when instances are invalidated. This fixes an O(n^2) performance bug when updating <use> trees. BUG=565120 ==========
I found this while investigating 565117 but when I started looking into 565120... this was the root cause. Change description updated to reflect that.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL) win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL) win_chromium_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL) win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by fs@opera.com
lgtm On 2015/12/05 at 03:15:25, pdr wrote: > I found this while investigating 565117 but when I started looking into 565120... this was the root cause. Change description updated to reflect that. Nice find regardless...
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1498323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1498323002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by pdr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1498323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1498323002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Remove updateLayoutTreeIfNeeded from SVGElement::invalidateInstances There is no need to update the layout tree when instances are invalidated. This fixes an O(n^2) performance bug when updating <use> trees. BUG=565120 ========== to ========== Remove updateLayoutTreeIfNeeded from SVGElement::invalidateInstances There is no need to update the layout tree when instances are invalidated. This fixes an O(n^2) performance bug when updating <use> trees. BUG=565120 Committed: https://crrev.com/491876565010e0d7d4a036460188a66c2b34c946 Cr-Commit-Position: refs/heads/master@{#363393} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/491876565010e0d7d4a036460188a66c2b34c946 Cr-Commit-Position: refs/heads/master@{#363393} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
