Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1498293002: report back colorfilters in lua (Closed)

Created:
5 years ago by reed1
Modified:
5 years ago
Reviewers:
reed2, robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

report back colorfilters in lua BUG=skia: TBR= Committed: https://skia.googlesource.com/skia/+/22a517f71aa6a0ebe0fbe71cb95d7c341a9e84fe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -19 lines) Patch
M src/utils/SkLua.cpp View 6 chunks +33 lines, -0 lines 0 comments Download
A + tools/lua/filter-counter.lua View 3 chunks +30 lines, -19 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
reed1
5 years ago (2015-12-04 23:23:53 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1498293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1498293002/1
5 years ago (2015-12-04 23:25:35 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Mac10.9-Clang-Arm7-Debug-iOS-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac10.9-Clang-Arm7-Debug-iOS-Trybot/builds/15)
5 years ago (2015-12-04 23:47:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1498293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1498293002/1
5 years ago (2015-12-05 04:43:13 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/22a517f71aa6a0ebe0fbe71cb95d7c341a9e84fe
5 years ago (2015-12-05 04:46:03 UTC) #11
robertphillips
5 years ago (2015-12-06 19:02:59 UTC) #12
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698