Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1498273002: Revert of Aura Android: upstream platform_util* related files (Closed)

Created:
5 years ago by David Trainor- moved to gerrit
Modified:
5 years ago
Reviewers:
sky, bshe, mfomitchev
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Aura Android: upstream platform_util* related files (patchset #2 id:20001 of https://codereview.chromium.org/1478493004/ ) Reason for revert: Causing build breakage when combined with https://codereview.chromium.org/1459793002. Original issue's description: > Aura Android: upstream platform_util* related files > > BUG=561669 > > Committed: https://crrev.com/ece92328ce4f995a74f227b225b5424edc67b4c0 > Cr-Commit-Position: refs/heads/master@{#363026} TBR=mfomitchev@chromium.org,sky@chromium.org,bshe@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=561669 Committed: https://crrev.com/c7c14f42d8d0b4235bf900c64f735700cc7780d5 Cr-Commit-Position: refs/heads/master@{#363311}

Patch Set 1 #

Patch Set 2 : Fix conflict #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -26 lines) Patch
M chrome/browser/BUILD.gn View 1 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/platform_util_aura.cc View 1 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
David Trainor- moved to gerrit
Created Revert of Aura Android: upstream platform_util* related files
5 years ago (2015-12-04 22:06:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1498273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1498273002/1
5 years ago (2015-12-04 22:09:39 UTC) #2
commit-bot: I haz the power
Failed to apply patch for chrome/browser/platform_util.h: While running git apply --index -3 -p1; error: patch ...
5 years ago (2015-12-04 22:12:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1498273002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1498273002/100001
5 years ago (2015-12-04 22:48:19 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:100001)
5 years ago (2015-12-04 23:01:36 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-04 23:07:47 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c7c14f42d8d0b4235bf900c64f735700cc7780d5
Cr-Commit-Position: refs/heads/master@{#363311}

Powered by Google App Engine
This is Rietveld 408576698