Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 1498163002: Add better error messages to git_reparent_branch. (Closed)

Created:
5 years ago by iannucci
Modified:
5 years ago
Reviewers:
dhsharp, Vadim Sh.
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : We already check for HEAD #

Patch Set 3 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M git_reparent_branch.py View 1 2 chunks +11 lines, -0 lines 0 comments Download
M tests/git_rebase_update_test.py View 1 2 1 chunk +8 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (3 generated)
iannucci
5 years ago (2015-12-04 18:41:06 UTC) #1
Vadim Sh.
lgtm
5 years ago (2015-12-04 18:42:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1498163002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1498163002/40001
5 years ago (2015-12-04 19:01:08 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-04 19:03:25 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=297848

Powered by Google App Engine
This is Rietveld 408576698