Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1029)

Unified Diff: util/stdlib/aligned_allocator_test.cc

Issue 1498133002: Add AlignedVector and use it for vector<MEMORY_BASIC_INFORMATION64> (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Address review feedback Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « util/stdlib/aligned_allocator.cc ('k') | util/util.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/stdlib/aligned_allocator_test.cc
diff --git a/util/stdlib/aligned_allocator_test.cc b/util/stdlib/aligned_allocator_test.cc
new file mode 100644
index 0000000000000000000000000000000000000000..fe3b9e65dbd00fc007829e539612d1e873d084eb
--- /dev/null
+++ b/util/stdlib/aligned_allocator_test.cc
@@ -0,0 +1,117 @@
+// Copyright 2015 The Crashpad Authors. All rights reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include "util/stdlib/aligned_allocator.h"
+
+#include <stdint.h>
+
+#include "gtest/gtest.h"
+
+#if defined(OS_WIN)
+#include <crtdbg.h>
+#endif
+
+namespace crashpad {
+namespace test {
+namespace {
+
+bool IsAligned(void* pointer, size_t alignment) {
+ uintptr_t address = reinterpret_cast<uintptr_t>(pointer);
+ return (address & (alignment - 1)) == 0;
+}
+
+TEST(AlignedAllocator, AlignedVector) {
+ // Test a structure with natural alignment.
+ struct NaturalAlignedStruct {
+ int i;
+ };
+
+ AlignedVector<NaturalAlignedStruct> natural_aligned_vector;
+ natural_aligned_vector.push_back(NaturalAlignedStruct());
+ EXPECT_TRUE(
+ IsAligned(&natural_aligned_vector[0], ALIGNOF(NaturalAlignedStruct)));
+
+ natural_aligned_vector.resize(3);
+ EXPECT_TRUE(
+ IsAligned(&natural_aligned_vector[0], ALIGNOF(NaturalAlignedStruct)));
+ EXPECT_TRUE(
+ IsAligned(&natural_aligned_vector[1], ALIGNOF(NaturalAlignedStruct)));
+ EXPECT_TRUE(
+ IsAligned(&natural_aligned_vector[2], ALIGNOF(NaturalAlignedStruct)));
+
+ // Test a structure that declares its own alignment.
+ struct ALIGNAS(32) AlignedStruct {
+ int i;
+ };
+ ASSERT_EQ(32u, ALIGNOF(AlignedStruct));
+
+ AlignedVector<AlignedStruct> aligned_vector;
+ aligned_vector.push_back(AlignedStruct());
+ EXPECT_TRUE(IsAligned(&aligned_vector[0], ALIGNOF(AlignedStruct)));
+
+ aligned_vector.resize(3);
+ EXPECT_TRUE(IsAligned(&aligned_vector[0], ALIGNOF(AlignedStruct)));
+ EXPECT_TRUE(IsAligned(&aligned_vector[1], ALIGNOF(AlignedStruct)));
+ EXPECT_TRUE(IsAligned(&aligned_vector[2], ALIGNOF(AlignedStruct)));
+
+ // Try a custom alignment. Since the structure itself doesn’t specify an
+ // alignment constraint, only the base address will be aligned to the
+ // requested boundary.
+ AlignedVector<NaturalAlignedStruct, 64> custom_aligned_vector;
+ custom_aligned_vector.push_back(NaturalAlignedStruct());
+ EXPECT_TRUE(IsAligned(&custom_aligned_vector[0], 64));
+
+ // Try a structure with a pretty big alignment request.
+ struct ALIGNAS(1024) BigAlignedStruct {
+ int i;
+ };
+ ASSERT_EQ(1024u, ALIGNOF(BigAlignedStruct));
+
+ AlignedVector<BigAlignedStruct> big_aligned_vector;
+ big_aligned_vector.push_back(BigAlignedStruct());
+ EXPECT_TRUE(IsAligned(&big_aligned_vector[0], ALIGNOF(BigAlignedStruct)));
+
+ big_aligned_vector.resize(3);
+ EXPECT_TRUE(IsAligned(&big_aligned_vector[0], ALIGNOF(BigAlignedStruct)));
+ EXPECT_TRUE(IsAligned(&big_aligned_vector[1], ALIGNOF(BigAlignedStruct)));
+ EXPECT_TRUE(IsAligned(&big_aligned_vector[2], ALIGNOF(BigAlignedStruct)));
+}
+
+void BadAlignmentTest() {
+#if defined(OS_WIN)
+ // Suppress the assertion MessageBox() normally displayed by the CRT in debug
+ // mode.
+ int previous = _CrtSetReportMode(_CRT_ASSERT, _CRTDBG_MODE_DEBUG);
+
+ // In release mode, _CrtSetReportMode() is #defined to ((int)0), so |previous|
+ // would appear unused.
+ ALLOW_UNUSED_LOCAL(previous);
+#endif
+
+ // Alignment constraints must be powers of 2. 7 is not valid.
+ AlignedVector<int, 7> bad_aligned_vector;
+ bad_aligned_vector.push_back(0);
+
+#if defined(OS_WIN)
+ _CrtSetReportMode(_CRT_ASSERT, previous);
+#endif
+}
+
+TEST(AlignedAllocatorDeathTest, BadAlignment) {
+ ASSERT_DEATH(BadAlignmentTest(), "");
+}
+
+} // namespace
+} // namespace test
+} // namespace crashpad
« no previous file with comments | « util/stdlib/aligned_allocator.cc ('k') | util/util.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698