Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1498093002: Revert of [Telemetry] Set the number of processes to use for telemetry_unittests on win (Closed)

Created:
5 years ago by nednguyen
Modified:
5 years ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Telemetry] Set the number of processes to use for telemetry_unittests on win platform to be 1 (patchset #3 id:40001 of https://codereview.chromium.org/1471673003/ ) Reason for revert: crbug.com/559154 should be fixed Original issue's description: > Set the number of processes to use for telemetry_unittests on > win platform to be 1 to temporarily fix the race condition on > win bot. > Cr-Commit-Position: refs/heads/master@{#361170} TBR=maruel@chromium.org NOTRY=true BUG=559154 Committed: https://crrev.com/7a61e826d13ad9093ff81b6f566baeacd9494254 Cr-Commit-Position: refs/heads/master@{#363326}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add trailing comma #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -19 lines) Patch
M chrome/telemetry_unittests.isolate View 1 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 26 (14 generated)
nednguyen
Created Revert of [Telemetry] Set the number of processes to use for telemetry_unittests on win ...
5 years ago (2015-12-04 16:51:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1498093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1498093002/1
5 years ago (2015-12-04 16:53:21 UTC) #4
M-A Ruel
lgtm https://codereview.chromium.org/1498093002/diff/1/chrome/telemetry_unittests.isolate File chrome/telemetry_unittests.isolate (right): https://codereview.chromium.org/1498093002/diff/1/chrome/telemetry_unittests.isolate#newcode23 chrome/telemetry_unittests.isolate:23: '..' I'd prefer to keep the comma. :)
5 years ago (2015-12-04 17:41:35 UTC) #5
nednguyen
https://codereview.chromium.org/1498093002/diff/1/chrome/telemetry_unittests.isolate File chrome/telemetry_unittests.isolate (right): https://codereview.chromium.org/1498093002/diff/1/chrome/telemetry_unittests.isolate#newcode23 chrome/telemetry_unittests.isolate:23: '..' On 2015/12/04 17:41:35, M-A Ruel wrote: > I'd ...
5 years ago (2015-12-04 19:49:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1498093002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1498093002/40001
5 years ago (2015-12-04 19:51:08 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/155146) cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, ...
5 years ago (2015-12-04 19:59:18 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1498093002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1498093002/40001
5 years ago (2015-12-04 20:54:56 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/103316)
5 years ago (2015-12-05 00:00:21 UTC) #16
nednguyen
On 2015/12/05 00:00:21, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years ago (2015-12-05 00:09:09 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1498093002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1498093002/40001
5 years ago (2015-12-05 00:16:05 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years ago (2015-12-05 00:49:54 UTC) #24
commit-bot: I haz the power
5 years ago (2015-12-05 00:50:48 UTC) #26
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7a61e826d13ad9093ff81b6f566baeacd9494254
Cr-Commit-Position: refs/heads/master@{#363326}

Powered by Google App Engine
This is Rietveld 408576698