Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1498043002: Create a skeleton VisualDebugModule (Closed)

Created:
5 years ago by joshua.litt
Modified:
5 years ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Create a skeleton VisualDebugModule BUG=skia: Committed: https://skia.googlesource.com/skia/+/6ebd4239410dabf594e0d40ac610e92bf942b651

Patch Set 1 #

Patch Set 2 : tweak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -8 lines) Patch
M tools/VisualBench/VisualBench.cpp View 3 chunks +15 lines, -6 lines 0 comments Download
M tools/VisualBench/VisualBenchmarkStream.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/VisualBench/VisualBenchmarkStream.cpp View 2 chunks +6 lines, -1 line 0 comments Download
A tools/VisualBench/VisualDebugModule.h View 1 chunk +43 lines, -0 lines 0 comments Download
A tools/VisualBench/VisualDebugModule.cpp View 1 1 chunk +74 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
joshualitt
This gets us going down the right track.
5 years ago (2015-12-04 15:22:29 UTC) #2
bsalomon
lgtm
5 years ago (2015-12-04 16:47:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1498043002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1498043002/20001
5 years ago (2015-12-04 16:47:25 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-04 17:02:36 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/6ebd4239410dabf594e0d40ac610e92bf942b651

Powered by Google App Engine
This is Rietveld 408576698