Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issue 149803008: Reland r247589:<webview>: Fix text selection features in mac. (Closed)

Created:
6 years, 10 months ago by lazyboy
Modified:
6 years, 10 months ago
Reviewers:
CC:
chromium-reviews, extensions-reviews_chromium.org, tfarina, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Reland r247589: <webview>: Fix text selection features in mac. The suspected test flake (Shim_ScreenshotCapture) is not relevant. That test was also disabled in r247867. > <webview>: Fix text selection features in mac. > We still need to pass RWHVGuest::SelectionChanged() call to platform_view_. > This broke while adding IME support, this function doesn't seem to be required for IME (made sure by running BrowserPluginHostTest.InputMethod). > > Wrote a browser_test to catch the regression. > TBR=sky@chromium.org BUG=331722 Test=Open a <webview> in a chrome app. Select some text. Observe that "Look up in dictionary" and "Speech=>Start Speaking" features work. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249220

Patch Set 1 #

Messages

Total messages: 7 (0 generated)
lazyboy
The CQ bit was checked by lazyboy@chromium.org
6 years, 10 months ago (2014-02-05 19:46:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/149803008/1
6 years, 10 months ago (2014-02-05 19:59:43 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-05 21:49:00 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=258102
6 years, 10 months ago (2014-02-05 21:49:00 UTC) #4
lazyboy
The CQ bit was checked by lazyboy@chromium.org
6 years, 10 months ago (2014-02-05 21:54:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/149803008/1
6 years, 10 months ago (2014-02-05 22:00:12 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-02-06 02:07:56 UTC) #7
Message was sent while issue was closed.
Change committed as 249220

Powered by Google App Engine
This is Rietveld 408576698