This CL replaces e-mail with AccountId in wallpaper manager code.

This CL replaces e-mail with AccountId in wallpaper manager code.

This is part of transition to AccountId.

BUG=462823
TEST=manual

Committed: https://crrev.com/2aaa9658289f0d38402d91d66139fb7a20f297f2
Cr-Commit-Position: refs/heads/master@{#363715}

[Alexander Alekseev, 2015-12-04 10:43:36]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-04 10:43:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1497973002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1497973002/1

[Alexander Alekseev, 2015-12-04 10:47:56]

alemate@chromium.org changed reviewers:
+ bshe@chromium.org, stevenjb@chromium.org

[Alexander Alekseev, 2015-12-04 10:47:56]

Please review:

bshe@ : *wallpaper* code:
  c/b/c/background/ash_user_wallpaper_delegate.cc
  c/b/c/extensions/wallpaper_api.cc
  c/b/c/extensions/wallpaper_api.h
  c/b/c/extensions/wallpaper_private_api.cc
  c/b/c/extensions/wallpaper_private_api.h
  c/b/c/login/users/wallpaper/wallpaper_manager.cc
  c/b/c/login/users/wallpaper/wallpaper_manager.h
  c/b/c/login/users/wallpaper/wallpaper_manager_browsertest.cc
  c/b/c/login/users/wallpaper/wallpaper_manager_policy_browsertest.cc
  c/b/c/login/users/wallpaper/wallpaper_manager_test_utils.cc
  c/b/c/login/users/wallpaper/wallpaper_manager_unittest.cc
  components/wallpaper/wallpaper_manager_base.cc
  components/wallpaper/wallpaper_manager_base.h

stevenjb@ : Everything else:
achuith@ :
  c/b/c/customization/customization_wallpaper_downloader_browsertest.cc
  c/b/c/login/app_launch_signin_screen.cc
  c/b/c/login/app_launch_signin_screen.h
  c/b/c/login/ui/user_adding_screen.cc
  c/b/c/login/ui/webui_login_display.cc
  c/b/c/login/ui/webui_login_display.h
  c/b/c/login/users/chrome_user_manager_impl.cc
  c/b/c/login/users/fake_chrome_user_manager.cc
  c/b/ui/webui/chromeos/login/gaia_screen_handler.cc
  c/b/ui/webui/chromeos/login/signin_screen_handler.cc
  c/b/ui/webui/chromeos/login/signin_screen_handler.h
  c/b/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc

[Alexander Alekseev, 2015-12-04 10:49:34]

(The previous message had a typo.)

Please review:

bshe@ : *wallpaper* code:
  c/b/c/background/ash_user_wallpaper_delegate.cc
  c/b/c/extensions/wallpaper_api.cc
  c/b/c/extensions/wallpaper_api.h
  c/b/c/extensions/wallpaper_private_api.cc
  c/b/c/extensions/wallpaper_private_api.h
  c/b/c/login/users/wallpaper/wallpaper_manager.cc
  c/b/c/login/users/wallpaper/wallpaper_manager.h
  c/b/c/login/users/wallpaper/wallpaper_manager_browsertest.cc
  c/b/c/login/users/wallpaper/wallpaper_manager_policy_browsertest.cc
  c/b/c/login/users/wallpaper/wallpaper_manager_test_utils.cc
  c/b/c/login/users/wallpaper/wallpaper_manager_unittest.cc
  components/wallpaper/wallpaper_manager_base.cc
  components/wallpaper/wallpaper_manager_base.h

stevenjb@ : Everything else:
  c/b/c/customization/customization_wallpaper_downloader_browsertest.cc
  c/b/c/login/app_launch_signin_screen.cc
  c/b/c/login/app_launch_signin_screen.h
  c/b/c/login/ui/user_adding_screen.cc
  c/b/c/login/ui/webui_login_display.cc
  c/b/c/login/ui/webui_login_display.h
  c/b/c/login/users/chrome_user_manager_impl.cc
  c/b/c/login/users/fake_chrome_user_manager.cc
  c/b/ui/webui/chromeos/login/gaia_screen_handler.cc
  c/b/ui/webui/chromeos/login/signin_screen_handler.cc
  c/b/ui/webui/chromeos/login/signin_screen_handler.h
  c/b/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc

[commit-bot: I haz the power, 2015-12-04 11:34:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-04 11:34:44]

Dry run: This issue passed the CQ dry run.

[stevenjb, 2015-12-04 17:08:53]

lgtm

https://codereview.chromium.org/1497973002/diff/1/chrome/browser/ui/ash/multi...
File
chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc
(right):

https://codereview.chromium.org/1497973002/diff/1/chrome/browser/ui/ash/multi...
chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc:1019:
EXPECT_EQ("->{\"email\":\"B\",\"gaia_id\":\"\"}",
Let's make this (and any other similar strings) a const.

https://codereview.chromium.org/1497973002/diff/1/chrome/browser/ui/webui/chr...
File chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc (right):

https://codereview.chromium.org/1497973002/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc:749:
populated_email_, std::string()));
{}

https://codereview.chromium.org/1497973002/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc:749:
populated_email_, std::string()));
Also, FWIW, we seem to make a fair number of GetKnownUserAccountId(email,
string()). It might be nice to have a GetKnownUserAccountIdFromEmail(email)
instead.

[Alexander Alekseev, 2015-12-05 06:04:47]

https://codereview.chromium.org/1497973002/diff/1/chrome/browser/ui/ash/multi...
File
chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc
(right):

https://codereview.chromium.org/1497973002/diff/1/chrome/browser/ui/ash/multi...
chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc:1019:
EXPECT_EQ("->{\"email\":\"B\",\"gaia_id\":\"\"}",
On 2015/12/04 17:08:53, stevenjb wrote:
> Let's make this (and any other similar strings) a const.
> 

Done.

https://codereview.chromium.org/1497973002/diff/1/chrome/browser/ui/webui/chr...
File chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc (right):

https://codereview.chromium.org/1497973002/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc:749:
populated_email_, std::string()));
On 2015/12/04 17:08:53, stevenjb wrote:
> Also, FWIW, we seem to make a fair number of GetKnownUserAccountId(email,
> string()). It might be nice to have a GetKnownUserAccountIdFromEmail(email)
> instead.

I hope most of calls are temporary and will be removed after migration. Let's
postpone this idea to some time later.

https://codereview.chromium.org/1497973002/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc:749:
populated_email_, std::string()));
On 2015/12/04 17:08:53, stevenjb wrote:
> {}

Done.

[Alexander Alekseev, 2015-12-05 06:05:12]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-05 06:05:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1497973002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1497973002/20001

[commit-bot: I haz the power, 2015-12-05 08:06:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-05 08:06:58]

Dry run: Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL)
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build
URL)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build
URL)

[bshe, 2015-12-07 14:51:03]

On 2015/12/05 08:06:58, commit-bot: I haz the power wrote:
> Dry run: Try jobs failed on following builders:
>   win8_chromium_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL)
>   win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_TIMED_OUT, no
build
> URL)
>   win_chromium_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL)
>   win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build
> URL)

lgtm

[Alexander Alekseev, 2015-12-08 01:31:11]

The CQ bit was checked by alemate@chromium.org

[Alexander Alekseev, 2015-12-08 01:31:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/1497973002/#ps20001
(title: "Update after review.")

[commit-bot: I haz the power, 2015-12-08 01:34:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1497973002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1497973002/20001

[commit-bot: I haz the power, 2015-12-08 02:40:03]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-08 02:40:59]

Description was changed from

==========
This CL replaces e-mail with AccountId in wallpaper manager code.

This is part of transition to AccountId.

BUG=462823
TEST=manual
==========

to

==========
This CL replaces e-mail with AccountId in wallpaper manager code.

This is part of transition to AccountId.

BUG=462823
TEST=manual

Committed: https://crrev.com/2aaa9658289f0d38402d91d66139fb7a20f297f2
Cr-Commit-Position: refs/heads/master@{#363715}
==========

[commit-bot: I haz the power, 2015-12-08 02:41:00]

Patchset 2 (id:??) landed as
https://crrev.com/2aaa9658289f0d38402d91d66139fb7a20f297f2
Cr-Commit-Position: refs/heads/master@{#363715}