base/compiler_specific.h - Issue 1497963002: [DO NOT COMMIT] Use C++11 alignof/alignas everywhere.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/compiler_specific.h

Issue 1497963002: [DO NOT COMMIT] Use C++11 alignof/alignas everywhere. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Give up on alignas. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/compiler_specific.h

diff --git a/base/compiler_specific.h b/base/compiler_specific.h

index 402bc5ddb691d1b030cfd029f3e0eb33dc2a107d..1cfb4e908abc7eeda28e48396fc54b55457405fd 100644

--- a/base/compiler_specific.h

+++ b/base/compiler_specific.h

@@ -113,11 +113,7 @@

// Return the byte alignment of the given type (available at compile time).

// Use like:

// ALIGNOF(int32) // this would be 4

-#if defined(COMPILER_MSVC)

-#define ALIGNOF(type) __alignof(type)

-#elif defined(COMPILER_GCC)

-#define ALIGNOF(type) __alignof__(type)

-#endif

+#define ALIGNOF(type) alignof(type)

// Annotate a function indicating the caller must examine the return value.

// Use like:

« no previous file with comments | « no previous file | base/memory/aligned_memory_unittest.cc » ('j') | no next file with comments »