Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 1497903002: [turbofan] Lower calls to the Number constructor in JSCallReducer. (Closed)

Created:
5 years ago by Benedikt Meurer
Modified:
5 years ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Lower calls to the Number constructor in JSCallReducer. The expression Number(x) is essentially equivalent to ToNumber(x), so just lower to JSToNumber in the JSCallReducer and let typing and typed lowering take care of optimizations. R=jarin@chromium.org Committed: https://crrev.com/832424cf73c98b38421c4b2e3da8c0e02a127791 Cr-Commit-Position: refs/heads/master@{#32596}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -2 lines) Patch
M src/compiler/js-call-reducer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-call-reducer.cc View 3 chunks +23 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
5 years ago (2015-12-04 05:30:01 UTC) #1
Benedikt Meurer
Hey Jaro, Easy optimization (thanks to TurboFan). Please take a look. Thanks, Benedikt
5 years ago (2015-12-04 05:30:35 UTC) #2
Jarin
lgtm
5 years ago (2015-12-04 06:02:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1497903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1497903002/1
5 years ago (2015-12-04 06:03:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-04 06:04:24 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-04 06:04:50 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/832424cf73c98b38421c4b2e3da8c0e02a127791
Cr-Commit-Position: refs/heads/master@{#32596}

Powered by Google App Engine
This is Rietveld 408576698