unittests for Chromoting native messaging host.

remoting/host/setup/native_messaging_host.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_HOST_SETUP_NATIVE_MESSAGING_HOST_H_
 #define REMOTING_HOST_SETUP_NATIVE_MESSAGING_HOST_H_
 
 #include "base/callback_forward.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 21 matching lines @@
       const base::Closure& quit_closure);
   ~NativeMessagingHost();
 
   // Starts reading and processing messages.
   void Start();
 
   // Posts |quit_closure| to |caller_task_runner|. This gets called whenever an
   // error is encountered during reading and processing messages.
   void Shutdown();
 
+  // Allow unittests to use a mock DaemonController instance.
+  void SetDaemonControllerForTest(

[Sergey Ulanov, 2013/05/18 01:59:31]

can daemon_controller be passed to the constructor? Then you wouldn't need this
method.

[Lambros, 2013/05/22 21:42:18]

Done.

+      scoped_ptr<DaemonController> daemon_controller);
+
  private:
   // Processes a message received from the client app.
   void ProcessMessage(scoped_ptr<base::Value> message);
 
   // These "Process.." methods handle specific request types. The |response|
   // dictionary is pre-filled by ProcessMessage() with the parts of the
   // response already known ("id" and "type" fields).
   bool ProcessHello(const base::DictionaryValue& message,
                     scoped_ptr<base::DictionaryValue> response);
   bool ProcessGetHostName(const base::DictionaryValue& message,
@@ skipping 20 matching lines @@
   // PostTask()s to the main thread if necessary.
   void SendResponse(scoped_ptr<base::DictionaryValue> response);
 
   // These Send... methods get called on the DaemonController's internal thread
   // These methods fill in the |response| dictionary from the other parameters,
   // and pass it to SendResponse().
   void SendUpdateConfigResponse(scoped_ptr<base::DictionaryValue> response,
                                 DaemonController::AsyncResult result);
   void SendConfigResponse(scoped_ptr<base::DictionaryValue> response,
                           scoped_ptr<base::DictionaryValue> config);
-  void SendUsageStatsConsentResponse(
-      scoped_ptr<base::DictionaryValue> response,
-      bool supported,
-      bool allowed,
-      bool set_by_policy);
+  void SendUsageStatsConsentResponse(scoped_ptr<base::DictionaryValue> response,
+                                     bool supported,
+                                     bool allowed,
+                                     bool set_by_policy);
   void SendAsyncResult(scoped_ptr<base::DictionaryValue> response,
                        DaemonController::AsyncResult result);
 
   // Callbacks may be invoked by e.g. DaemonController during destruction,
   // which use |weak_ptr_|, so it's important that it be the last member to be
   // destroyed.
   base::WeakPtr<NativeMessagingHost> weak_ptr_;
 
   scoped_refptr<base::SingleThreadTaskRunner> caller_task_runner_;
   base::Closure quit_closure_;
 
   NativeMessagingReader native_messaging_reader_;
   NativeMessagingWriter native_messaging_writer_;
 
   // The DaemonController may post tasks to this object during destruction (but
   // not afterwards), so it needs to be destroyed before other members of this
   // class (except for |weak_factory_|).
   scoped_ptr<remoting::DaemonController> daemon_controller_;
 
   base::WeakPtrFactory<NativeMessagingHost> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(NativeMessagingHost);
 };
 
 }  // namespace remoting
 
 #endif  // REMOTING_HOST_SETUP_NATIVE_MESSAGING_HOST_H_