[heap] Clean up stale store buffer entries for aborted pages.

[heap] Clean up stale store buffer entries for aborted pages.

Fix the missed store buffer entries for live objects on aborted pages. Marking
the page as scan_on_scavenge takes care of rebuilding the entries. Note that
this requires an additional case in the rebuilding logic as we cannot iterate an
aborted pages using the object layout, but rather have to use mark bits for
this.

BUG=chromium:524425, chromium:564498
LOG=N

Committed: https://crrev.com/26fcd8300b1f07b78209de3d48466dc0a713b402
Cr-Commit-Position: refs/heads/master@{#32610}

[Michael Lippautz, 2015-12-04 10:46:39]

Description was changed from

==========
[heap] Clean up stale store buffer entries for aborted pages.

BUG=chromium:524425, chromium:564498
LOG=N
==========

to

==========
[heap] Clean up stale store buffer entries for aborted pages.

We missed store buffer entries for live objects on aborted pages. Marking the
page as scan_on_scavenge takes care of rebuilding the entries. Note that this
requires an additional case in the rebuilding logic as we cannot iterate an
aborted pages using the object layout, but rather have to use mark bits for
this.

BUG=chromium:524425, chromium:564498
LOG=N
==========

[Michael Lippautz, 2015-12-04 10:47:12]

Description was changed from

==========
[heap] Clean up stale store buffer entries for aborted pages.

We missed store buffer entries for live objects on aborted pages. Marking the
page as scan_on_scavenge takes care of rebuilding the entries. Note that this
requires an additional case in the rebuilding logic as we cannot iterate an
aborted pages using the object layout, but rather have to use mark bits for
this.

BUG=chromium:524425, chromium:564498
LOG=N
==========

to

==========
[heap] Clean up stale store buffer entries for aborted pages.

Fix the missed store buffer entries for live objects on aborted pages. Marking
the page as scan_on_scavenge takes care of rebuilding the entries. Note that
this requires an additional case in the rebuilding logic as we cannot iterate an
aborted pages using the object layout, but rather have to use mark bits for
this.

BUG=chromium:524425, chromium:564498
LOG=N
==========

[Michael Lippautz, 2015-12-04 10:48:00]

Patchset #1 (id:1) has been deleted

[Michael Lippautz, 2015-12-04 10:48:57]

mlippautz@chromium.org changed reviewers:
+ hpayer@chromium.org

[Michael Lippautz, 2015-12-04 10:48:58]

PTAL, this fixes the fix

https://codereview.chromium.org/1497883003/diff/20001/src/heap/mark-compact.h
File src/heap/mark-compact.h (right):

https://codereview.chromium.org/1497883003/diff/20001/src/heap/mark-compact.h...
src/heap/mark-compact.h:797: friend class StoreBuffer;
This is needed because we otherwise would not be able to access
VisitLiveObjects() from within the store buffer.

Maybe we could at some point have something like a LiveObjectIterator(Page*)
that uses markbit information.

[Hannes Payer (out of office), 2015-12-04 11:29:10]

LGTM!

The dependencies are really complicated in this function :/

https://codereview.chromium.org/1497883003/diff/20001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/1497883003/diff/20001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:3687: // stopping recording of slots for it in the
following pointer
I just stumbled over this comment: where to we record slots in the following
phases? I think we just update slots.

[Michael Lippautz, 2015-12-04 11:34:19]

https://codereview.chromium.org/1497883003/diff/20001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/1497883003/diff/20001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:3687: // stopping recording of slots for it in the
following pointer
On 2015/12/04 11:29:10, Hannes Payer wrote:
> I just stumbled over this comment: where to we record slots in the following
> phases? I think we just update slots.

The comment was wrong. I removed it.

[Michael Lippautz, 2015-12-04 11:34:23]

The CQ bit was checked by mlippautz@chromium.org

[Michael Lippautz, 2015-12-04 11:34:24]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/1497883003/#ps40001
(title: "Removed wrong comment")

[commit-bot: I haz the power, 2015-12-04 11:34:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1497883003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1497883003/40001

[commit-bot: I haz the power, 2015-12-04 12:11:00]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-12-04 12:11:14]

Description was changed from

==========
[heap] Clean up stale store buffer entries for aborted pages.

Fix the missed store buffer entries for live objects on aborted pages. Marking
the page as scan_on_scavenge takes care of rebuilding the entries. Note that
this requires an additional case in the rebuilding logic as we cannot iterate an
aborted pages using the object layout, but rather have to use mark bits for
this.

BUG=chromium:524425, chromium:564498
LOG=N
==========

to

==========
[heap] Clean up stale store buffer entries for aborted pages.

Fix the missed store buffer entries for live objects on aborted pages. Marking
the page as scan_on_scavenge takes care of rebuilding the entries. Note that
this requires an additional case in the rebuilding logic as we cannot iterate an
aborted pages using the object layout, but rather have to use mark bits for
this.

BUG=chromium:524425, chromium:564498
LOG=N

Committed: https://crrev.com/26fcd8300b1f07b78209de3d48466dc0a713b402
Cr-Commit-Position: refs/heads/master@{#32610}
==========

[commit-bot: I haz the power, 2015-12-04 12:11:14]

Patchset 2 (id:??) landed as
https://crrev.com/26fcd8300b1f07b78209de3d48466dc0a713b402
Cr-Commit-Position: refs/heads/master@{#32610}