Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(762)

Unified Diff: third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.idl

Issue 1497883002: MediaRecorder: update to spec (1/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: peter@s comments: add tests for BlobEvent ctor and reordered MediaRecorder.idl to match spec Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/mediarecorder/BlobEventInit.idl ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.idl
diff --git a/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.idl b/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.idl
index 2b92f95e497e1899a165223dba9f89df298e5c6e..add92ddccd219e874cec46c3b3b0822eae72f4ee 100644
--- a/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.idl
+++ b/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.idl
@@ -4,22 +4,20 @@
// https://w3c.github.io/mediacapture-record/MediaRecorder.html#MediaRecorderAPI
-enum RecordingStateEnum { "inactive", "recording", "paused" };
+enum RecordingState { "inactive", "recording", "paused" };
[
GarbageCollected,
ActiveDOMObject,
// TODO(mcasas): consider changing |mimeType| to a dictionary with said key, see https://github.com/w3c/mediacapture-record/issues/19
- // TODO(mcasas): Remove [TreatUndefinedAs], see https://github.com/w3c/mediacapture-record/issues/7
- Constructor(MediaStream stream, [TreatUndefinedAs=Missing] optional DOMString mimeType),
+ Constructor(MediaStream stream, optional DOMString mimeType),
ConstructorCallWith=ExecutionContext,
RaisesException=Constructor,
RuntimeEnabled=MediaRecorder,
] interface MediaRecorder : EventTarget {
readonly attribute MediaStream stream;
readonly attribute DOMString mimeType;
- readonly attribute RecordingStateEnum state;
- attribute boolean ignoreMutedMedia;
+ readonly attribute RecordingState state;
attribute EventHandler onstart;
attribute EventHandler onstop;
@@ -27,6 +25,7 @@ enum RecordingStateEnum { "inactive", "recording", "paused" };
attribute EventHandler onpause;
attribute EventHandler onresume;
attribute EventHandler onerror;
+ attribute boolean ignoreMutedMedia;
[RaisesException] void start(optional long timeslice);
[RaisesException] void stop();
« no previous file with comments | « third_party/WebKit/Source/modules/mediarecorder/BlobEventInit.idl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698