third_party/WebKit/Source/modules/mediarecorder/BlobEventInit.idl - Issue 1497883002: MediaRecorder: update to spec (1/3)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/mediarecorder/BlobEventInit.idl

Issue 1497883002: MediaRecorder: update to spec (1/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: s/eventInit/eventInitDict/ Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 dictionary BlobEventInit : EventInit {	5 dictionary BlobEventInit : EventInit {

6 Blob? blob = null;	6 required Blob data;
	Peter Beverloo 2015/12/09 23:11:29 nit: it might be interesting to add a simple test nit: it might be interesting to add a simple test to verify that this property and the BlobEvent constructor's arguments indeed are (and remain) required. mcasas 2015/12/10 02:16:59 Added them to LayoutTests's MediaRecorder-BlobEven Show quoted text On 2015/12/09 23:11:29, Peter Beverloo wrote: > nit: it might be interesting to add a simple test to verify that this property > and the BlobEvent constructor's arguments indeed are (and remain) required. Added them to LayoutTests's MediaRecorder-BlobEvent-basic.html
7 };	7 };

OLD	NEW