third_party/WebKit/Source/web/WebFontImpl.h - Issue 1497873002: Make DisplayItemClient an interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebFontImpl.h

Issue 1497873002: Make DisplayItemClient an interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix compile Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebFontImpl.h

diff --git a/third_party/WebKit/Source/web/WebFontImpl.h b/third_party/WebKit/Source/web/WebFontImpl.h

index b6c2378f65f09dd488c189496a72c2631afbb7fc..2929dcf4bd2e0e6a96f29528c6d3e2e5eaaf672d 100644

--- a/third_party/WebKit/Source/web/WebFontImpl.h

+++ b/third_party/WebKit/Source/web/WebFontImpl.h

@@ -39,7 +39,7 @@ namespace blink {

class FontDescription;

-class WebFontImpl final : public WebFont {

+class WebFontImpl final : public WebFont, public DisplayItemClient {

public:

explicit WebFontImpl(const FontDescription&);

@@ -59,8 +59,7 @@ public:

WebFloatRect selectionRectForText(const WebTextRun&, const WebFloatPoint& leftBaseline,

int height, int from = 0, int to = -1) const override;

- DisplayItemClient displayItemClient() const { return toDisplayItemClient(this); }

- String debugName() const { return "WebFontImpl"; }

+ String debugName() const final { return "WebFontImpl"; }

private:

Font m_font;