Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Unified Diff: third_party/WebKit/Source/core/frame/LocalFrame.h

Issue 1497873002: Make DisplayItemClient an interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix compile Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/LocalFrame.h
diff --git a/third_party/WebKit/Source/core/frame/LocalFrame.h b/third_party/WebKit/Source/core/frame/LocalFrame.h
index 32000d8e2ff04a14b82994d60274cc8274949460..3bb7e422a7706b7b9aec27e3bdeba0bb4fde6e67 100644
--- a/third_party/WebKit/Source/core/frame/LocalFrame.h
+++ b/third_party/WebKit/Source/core/frame/LocalFrame.h
@@ -76,7 +76,7 @@ class WebFrameHostScheduler;
class WebFrameScheduler;
template <typename Strategy> class PositionWithAffinityTemplate;
-class CORE_EXPORT LocalFrame : public Frame, public LocalFrameLifecycleNotifier, public WillBeHeapSupplementable<LocalFrame> {
+class CORE_EXPORT LocalFrame : public Frame, public LocalFrameLifecycleNotifier, public WillBeHeapSupplementable<LocalFrame>, public DisplayItemClient {
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(LocalFrame);
public:
static PassRefPtrWillBeRawPtr<LocalFrame> create(FrameLoaderClient*, FrameHost*, FrameOwner*);
@@ -179,8 +179,8 @@ public:
void unregisterPluginElement(HTMLPlugInElement*);
void clearWeakMembers(Visitor*);
#endif
- DisplayItemClient displayItemClient() const { return toDisplayItemClient(this); }
- String debugName() const { return "LocalFrame"; }
+
+ String debugName() const override { return "LocalFrame"; }
pdr. 2015/12/05 21:39:19 Should this be final?
Xianzhu 2015/12/07 17:14:00 Yes. Done.
bool shouldThrottleRendering() const;
@@ -203,7 +203,7 @@ private:
// Paints the area for the given rect into a DragImage, with the given displayItemClient id attached.
// The rect is in the coordinate space of the frame.
- PassOwnPtr<DragImage> paintIntoDragImage(const DisplayItemClientWrapper&,
+ PassOwnPtr<DragImage> paintIntoDragImage(const DisplayItemClient&,
RespectImageOrientationEnum shouldRespectImageOrientation, const GlobalPaintFlags,
IntRect paintingRect, float opacity = 1);

Powered by Google App Engine
This is Rietveld 408576698