third_party/WebKit/Source/platform/graphics/paint/SubsequenceRecorder.cpp - Issue 1497873002: Make DisplayItemClient an interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/SubsequenceRecorder.cpp

Issue 1497873002: Make DisplayItemClient an interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/paint/SubsequenceRecorder.h ('k') | third_party/WebKit/Source/platform/graphics/paint/Transform3DDisplayItem.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/paint/SubsequenceRecorder.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/paint/SubsequenceRecorder.cpp b/third_party/WebKit/Source/platform/graphics/paint/SubsequenceRecorder.cpp

index 45067bcca0de7b500fc2a34a4f40a62d89dcb873..50ac33ff24b828c43636a7646a105edd7a218e96 100644

--- a/third_party/WebKit/Source/platform/graphics/paint/SubsequenceRecorder.cpp

+++ b/third_party/WebKit/Source/platform/graphics/paint/SubsequenceRecorder.cpp

@@ -13,7 +13,7 @@

namespace blink {

-bool SubsequenceRecorder::useCachedSubsequenceIfPossible(GraphicsContext& context, const DisplayItemClientWrapper& client)

+bool SubsequenceRecorder::useCachedSubsequenceIfPossible(GraphicsContext& context, const DisplayItemClient& client)

{

if (!RuntimeEnabledFeatures::slimmingPaintSynchronizedPaintingEnabled())

return false;

@@ -21,7 +21,7 @@ bool SubsequenceRecorder::useCachedSubsequenceIfPossible(GraphicsContext& contex

if (context.paintController().displayItemConstructionIsDisabled())

return false;

- if (!context.paintController().clientCacheIsValid(client.displayItemClient()))

+ if (!context.paintController().clientCacheIsValid(client))

return false;

context.paintController().createAndAppend<CachedDisplayItem>(client, DisplayItem::CachedSubsequence);

@@ -36,7 +36,7 @@ bool SubsequenceRecorder::useCachedSubsequenceIfPossible(GraphicsContext& contex

return true;

}

-SubsequenceRecorder::SubsequenceRecorder(GraphicsContext& context, const DisplayItemClientWrapper& client)

+SubsequenceRecorder::SubsequenceRecorder(GraphicsContext& context, const DisplayItemClient& client)

: m_paintController(context.paintController())

, m_client(client)

, m_beginSubsequenceIndex(0)