third_party/WebKit/Source/platform/graphics/paint/PaintArtifactToSkCanvasTest.cpp - Issue 1497873002: Make DisplayItemClient an interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/PaintArtifactToSkCanvasTest.cpp

Issue 1497873002: Make DisplayItemClient an interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/paint/FloatClipDisplayItem.h ('k') | third_party/WebKit/Source/platform/graphics/paint/PaintController.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/paint/PaintArtifactToSkCanvasTest.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/paint/PaintArtifactToSkCanvasTest.cpp b/third_party/WebKit/Source/platform/graphics/paint/PaintArtifactToSkCanvasTest.cpp

index a1c29e114e75ec0c2a931dd859e13d2b35326740..e4753e1aab1f153f78666b0e81f8b6f92a9050c3 100644

--- a/third_party/WebKit/Source/platform/graphics/paint/PaintArtifactToSkCanvasTest.cpp

+++ b/third_party/WebKit/Source/platform/graphics/paint/PaintArtifactToSkCanvasTest.cpp

@@ -61,14 +61,13 @@ private:

}

};

-class DummyRectClient {

+class DummyRectClient : public DisplayItemClient {

public:

DummyRectClient(const SkRect& rect, SkColor color) : m_rect(rect), m_color(color) {}

const SkRect& rect() const { return m_rect; }

SkColor color() const { return m_color; }

PassRefPtr<SkPicture> makePicture() const { return pictureWithRect(m_rect, m_color); }

- DisplayItemClient displayItemClient() const { return toDisplayItemClient(this); }

- String debugName() const { return "<dummy>"; }

+ String debugName() const final { return "<dummy>"; }

private:

SkRect m_rect;