Fix disabled extensions for virtual contexts and respect command line.

Fix disabled extensions for virtual contexts and respect command line.

This CL fixes an issue with disabled extensions not working on devices
which use glGetStringi to get the extensions. It also now merges
extensions disabled on the command line instead of being overwritten by
extensions disabled in the bug workaround list.

R=zmo@chromium.org, sievers@chromium.org
BUG=554909
Committed: https://crrev.com/470e6c7d68a21e21abf3fec4ad7f1c495936db51
Cr-Commit-Position: refs/heads/master@{#363600}

[David Yen, 2015-12-03 23:15:36]

dyen@chromium.org changed reviewers:
+ sievers@chromium.org

[David Yen, 2015-12-03 23:15:36]

+sievers@ for gl_gl_api_implementation changes

[David Yen, 2015-12-03 23:19:17]

Description was changed from

==========
Fix disabled extensions for virtual contexts and respect command line.

This CL fixes an issue with disabled extensions not working on devices
which use glGetStringi to get the extensions. It also now merges
extensions disabled on the command line instead of being overwritten by
extensions disabled in the bug workaround list.

R=zmo@chromium.org
BUG=554909
==========

to

==========
Fix disabled extensions for virtual contexts and respect command line.

This CL fixes an issue with disabled extensions not working on devices
which use glGetStringi to get the extensions. It also now merges
extensions disabled on the command line instead of being overwritten by
extensions disabled in the bug workaround list.

R=zmo@chromium.org, sievers@chromium.org
BUG=554909
==========

[Zhenyao Mo, 2015-12-03 23:28:10]

https://codereview.chromium.org/1497863002/diff/1/content/browser/gpu/gpu_dat...
File content/browser/gpu/gpu_data_manager_impl_private.cc (right):

https://codereview.chromium.org/1497863002/diff/1/content/browser/gpu/gpu_dat...
content/browser/gpu/gpu_data_manager_impl_private.cc:589:
disabled_vec.insert(disabled_vec.end(),
Here you may insert the same extension twice if it's specified in the
commandline and also by the driver_bug_list.

[David Yen, 2015-12-04 00:10:53]

https://codereview.chromium.org/1497863002/diff/1/content/browser/gpu/gpu_dat...
File content/browser/gpu/gpu_data_manager_impl_private.cc (right):

https://codereview.chromium.org/1497863002/diff/1/content/browser/gpu/gpu_dat...
content/browser/gpu/gpu_data_manager_impl_private.cc:589:
disabled_vec.insert(disabled_vec.end(),
On 2015/12/03 23:28:10, Zhenyao Mo wrote:
> Here you may insert the same extension twice if it's specified in the
> commandline and also by the driver_bug_list.

Done.

[Zhenyao Mo, 2015-12-04 00:16:19]

On 2015/12/04 00:10:53, David Yen wrote:
>
https://codereview.chromium.org/1497863002/diff/1/content/browser/gpu/gpu_dat...
> File content/browser/gpu/gpu_data_manager_impl_private.cc (right):
> 
>
https://codereview.chromium.org/1497863002/diff/1/content/browser/gpu/gpu_dat...
> content/browser/gpu/gpu_data_manager_impl_private.cc:589:
> disabled_vec.insert(disabled_vec.end(),
> On 2015/12/03 23:28:10, Zhenyao Mo wrote:
> > Here you may insert the same extension twice if it's specified in the
> > commandline and also by the driver_bug_list.
> 
> Done.

LGTM

[no sievers, 2015-12-04 20:16:14]

https://codereview.chromium.org/1497863002/diff/40001/ui/gl/gl_gl_api_impleme...
File ui/gl/gl_gl_api_implementation.cc (right):

https://codereview.chromium.org/1497863002/diff/40001/ui/gl/gl_gl_api_impleme...
ui/gl/gl_gl_api_implementation.cc:607: case GL_EXTENSIONS:
did you mean GL_NUM_EXTENSIONS?

[David Yen, 2015-12-04 22:21:41]

https://codereview.chromium.org/1497863002/diff/40001/ui/gl/gl_gl_api_impleme...
File ui/gl/gl_gl_api_implementation.cc (right):

https://codereview.chromium.org/1497863002/diff/40001/ui/gl/gl_gl_api_impleme...
ui/gl/gl_gl_api_implementation.cc:607: case GL_EXTENSIONS:
On 2015/12/04 20:16:14, sievers wrote:
> did you mean GL_NUM_EXTENSIONS?

Ah yes, thank you for catching this. Done.

[no sievers, 2015-12-04 22:26:15]

lgtm

[David Yen, 2015-12-04 22:31:19]

The CQ bit was checked by dyen@chromium.org

[David Yen, 2015-12-04 22:31:20]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org
Link to the patchset: https://codereview.chromium.org/1497863002/#ps60001
(title: "Fixed GL_NUM_EXTENSIONS")

[commit-bot: I haz the power, 2015-12-04 22:48:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1497863002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1497863002/60001

[commit-bot: I haz the power, 2015-12-05 00:29:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-05 00:29:11]

Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL)
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build
URL)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build
URL)

[David Yen, 2015-12-07 18:37:19]

The CQ bit was checked by dyen@chromium.org

[commit-bot: I haz the power, 2015-12-07 18:39:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1497863002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1497863002/60001

[commit-bot: I haz the power, 2015-12-07 22:17:46]

Description was changed from

==========
Fix disabled extensions for virtual contexts and respect command line.

This CL fixes an issue with disabled extensions not working on devices
which use glGetStringi to get the extensions. It also now merges
extensions disabled on the command line instead of being overwritten by
extensions disabled in the bug workaround list.

R=zmo@chromium.org, sievers@chromium.org
BUG=554909
==========

to

==========
Fix disabled extensions for virtual contexts and respect command line.

This CL fixes an issue with disabled extensions not working on devices
which use glGetStringi to get the extensions. It also now merges
extensions disabled on the command line instead of being overwritten by
extensions disabled in the bug workaround list.

R=zmo@chromium.org, sievers@chromium.org
BUG=554909
==========

[commit-bot: I haz the power, 2015-12-07 22:17:47]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-12-07 22:18:52]

Description was changed from

==========
Fix disabled extensions for virtual contexts and respect command line.

This CL fixes an issue with disabled extensions not working on devices
which use glGetStringi to get the extensions. It also now merges
extensions disabled on the command line instead of being overwritten by
extensions disabled in the bug workaround list.

R=zmo@chromium.org, sievers@chromium.org
BUG=554909
==========

to

==========
Fix disabled extensions for virtual contexts and respect command line.

This CL fixes an issue with disabled extensions not working on devices
which use glGetStringi to get the extensions. It also now merges
extensions disabled on the command line instead of being overwritten by
extensions disabled in the bug workaround list.

R=zmo@chromium.org, sievers@chromium.org
BUG=554909

Committed: https://crrev.com/470e6c7d68a21e21abf3fec4ad7f1c495936db51
Cr-Commit-Position: refs/heads/master@{#363600}
==========

[commit-bot: I haz the power, 2015-12-07 22:18:53]

Patchset 4 (id:??) landed as
https://crrev.com/470e6c7d68a21e21abf3fec4ad7f1c495936db51
Cr-Commit-Position: refs/heads/master@{#363600}