Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 1497843002: mac: Back discardable shared memory with a Mach primitive. (Closed)

Created:
5 years ago by erikchen
Modified:
5 years ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, gavinp+memory_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mac: Back discardable shared memory with a Mach primitive. Discardable shared memory no longer relies on a POSIX fd backed shared memory region, as it no longer uses ftruncate. BUG=547239 Committed: https://crrev.com/9eb16f685f80cac468928277c6ccbd91ca373b0e Cr-Commit-Position: refs/heads/master@{#363045}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M base/memory/discardable_shared_memory.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1497843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1497843002/1
5 years ago (2015-12-03 18:46:54 UTC) #2
erikchen
mark: Please review.
5 years ago (2015-12-03 18:48:08 UTC) #4
Mark Mentovai
LGTM
5 years ago (2015-12-03 18:57:49 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-03 20:06:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1497843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1497843002/1
5 years ago (2015-12-03 20:19:44 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 20:27:38 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-03 20:28:24 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9eb16f685f80cac468928277c6ccbd91ca373b0e
Cr-Commit-Position: refs/heads/master@{#363045}

Powered by Google App Engine
This is Rietveld 408576698