allocator cleanup: set use_allocator=none for mac and ios

allocator cleanup: set use_allocator=none for mac and ios

Conversely to what the title suggests, this CL doesn't have
any real effect on mac/ios.
Rationale: today mac/ios have use_allocator:tcmalloc just because that
(tcmalloc) is the default value in common.gypi.
As a matter of facts, all the targets that include allocator.gyp
are conditioned by the flags os=win or os=linux (or variants)
and never actually depend on allocator on mac/ios.
In gn instead (see build/config/allocator.gni), use_allocator is
explicitly 'none' for mac and ios.

In essence this CL just re-establishes order in the value of
use_allocator on mac/ios in GYP, setting it to 'none'.

This is part of the allocator cleanup, phase 1
(see http://bit.ly/allocator-cleanup).
After this CL, the various gyp targets are still conditionally
depending on allocator.gyp. Those will be cleaned up in subsequent
CLs.

The effect of this CL can be seen in the diff ninja files:
os=mac:                          http://pastebin.com/UWvGRUz3
os=mac component=shared_library  http://pastebin.com/E8cdSZDe

The only difference there is that the targets 'allocator' and
'allocator_unittest' are not built anymore. Previously they where
built but not depended on.

BUG=564618
Committed: https://crrev.com/79a9c7f80d3059e696b8c8dd0e00546f3fa6edf8
Cr-Commit-Position: refs/heads/master@{#363182}

[Primiano Tucci (use gerrit), 2015-12-03 17:07:33]

Description was changed from

==========
allocator cleanup: set use_allocator=none for mac and ios

Conversely to what it looks, this CL doesn't have any final effect on
mac/ios.
Rationale: today mac/ios have use_allocator:tcmalloc just because that
(tcmalloc) is the default value in common.gypi.
As a matter of facts, all the targets that include allocator.gyp
are conditioned by the flags os=win or os=linux (or variants)
and never actually depend on allocator on mac/ios.

In essence this CL just re-establishes order in the value of
use_allocator on mac/ios, setting it to none.

The final effect can be double checked in the diff ninja files
for default build:       http://pastebin.com/UWvGRUz3
component=shared_library http://pastebin.com/E8cdSZDe

The only difference there is that the targets 'allocator' and
'allocator_unittest' are not built anymore. Previously they where
built but not depended on.

BUG=564618
==========

to

==========
allocator cleanup: set use_allocator=none for mac and ios

Conversely to what it looks, this CL doesn't have any real effect on
mac/ios.
Rationale: today mac/ios have use_allocator:tcmalloc just because that
(tcmalloc) is the default value in common.gypi.
As a matter of facts, all the targets that include allocator.gyp
are conditioned by the flags os=win or os=linux (or variants)
and never actually depend on allocator on mac/ios.
This is already the situation in gn (see build/config/allocator.gni)

In essence this CL just re-establishes order in the value of
use_allocator on mac/ios in GYP, setting it to 'none'.

This is part of the allocator cleanup, phase 1
(see http://bit.ly/allocator-cleanup).
After this CL, the various gyp targets are still 

The effect of this CL can be seen in the diff ninja files:
os=mac:                          http://pastebin.com/UWvGRUz3
os=mac component=shared_library  http://pastebin.com/E8cdSZDe

The only difference there is that the targets 'allocator' and
'allocator_unittest' are not built anymore. Previously they where
built but not depended on.

BUG=564618
==========

[Primiano Tucci (use gerrit), 2015-12-03 17:08:28]

Description was changed from

==========
allocator cleanup: set use_allocator=none for mac and ios

Conversely to what it looks, this CL doesn't have any real effect on
mac/ios.
Rationale: today mac/ios have use_allocator:tcmalloc just because that
(tcmalloc) is the default value in common.gypi.
As a matter of facts, all the targets that include allocator.gyp
are conditioned by the flags os=win or os=linux (or variants)
and never actually depend on allocator on mac/ios.
This is already the situation in gn (see build/config/allocator.gni)

In essence this CL just re-establishes order in the value of
use_allocator on mac/ios in GYP, setting it to 'none'.

This is part of the allocator cleanup, phase 1
(see http://bit.ly/allocator-cleanup).
After this CL, the various gyp targets are still 

The effect of this CL can be seen in the diff ninja files:
os=mac:                          http://pastebin.com/UWvGRUz3
os=mac component=shared_library  http://pastebin.com/E8cdSZDe

The only difference there is that the targets 'allocator' and
'allocator_unittest' are not built anymore. Previously they where
built but not depended on.

BUG=564618
==========

to

==========
allocator cleanup: set use_allocator=none for mac and ios

Conversely to what it looks, this CL doesn't have any real effect on
mac/ios.
Rationale: today mac/ios have use_allocator:tcmalloc just because that
(tcmalloc) is the default value in common.gypi.
As a matter of facts, all the targets that include allocator.gyp
are conditioned by the flags os=win or os=linux (or variants)
and never actually depend on allocator on mac/ios.
This is already the situation in gn (see build/config/allocator.gni)

In essence this CL just re-establishes order in the value of
use_allocator on mac/ios in GYP, setting it to 'none'.

This is part of the allocator cleanup, phase 1
(see http://bit.ly/allocator-cleanup).
After this CL, the various gyp targets are still conditionally
depending on allocator.gyp. Those will be cleaned up in subsequent
CLs.

The effect of this CL can be seen in the diff ninja files:
os=mac:                          http://pastebin.com/UWvGRUz3
os=mac component=shared_library  http://pastebin.com/E8cdSZDe

The only difference there is that the targets 'allocator' and
'allocator_unittest' are not built anymore. Previously they where
built but not depended on.

BUG=564618
==========

[Primiano Tucci (use gerrit), 2015-12-03 17:09:14]

primiano@chromium.org changed reviewers:
+ mark@chromium.org, thakis@chromium.org

[Primiano Tucci (use gerrit), 2015-12-03 17:09:15]

PTAL to this one liner (in the most insane file of our codebase)

[Primiano Tucci (use gerrit), 2015-12-03 17:13:12]

Description was changed from

==========
allocator cleanup: set use_allocator=none for mac and ios

Conversely to what it looks, this CL doesn't have any real effect on
mac/ios.
Rationale: today mac/ios have use_allocator:tcmalloc just because that
(tcmalloc) is the default value in common.gypi.
As a matter of facts, all the targets that include allocator.gyp
are conditioned by the flags os=win or os=linux (or variants)
and never actually depend on allocator on mac/ios.
This is already the situation in gn (see build/config/allocator.gni)

In essence this CL just re-establishes order in the value of
use_allocator on mac/ios in GYP, setting it to 'none'.

This is part of the allocator cleanup, phase 1
(see http://bit.ly/allocator-cleanup).
After this CL, the various gyp targets are still conditionally
depending on allocator.gyp. Those will be cleaned up in subsequent
CLs.

The effect of this CL can be seen in the diff ninja files:
os=mac:                          http://pastebin.com/UWvGRUz3
os=mac component=shared_library  http://pastebin.com/E8cdSZDe

The only difference there is that the targets 'allocator' and
'allocator_unittest' are not built anymore. Previously they where
built but not depended on.

BUG=564618
==========

to

==========
allocator cleanup: set use_allocator=none for mac and ios

Conversely to what the title suggests, this CL doesn't have 
any real effect on mac/ios.
Rationale: today mac/ios have use_allocator:tcmalloc just because that
(tcmalloc) is the default value in common.gypi.
As a matter of facts, all the targets that include allocator.gyp
are conditioned by the flags os=win or os=linux (or variants)
and never actually depend on allocator on mac/ios.
This is already the situation in gn (see build/config/allocator.gni)

In essence this CL just re-establishes order in the value of
use_allocator on mac/ios in GYP, setting it to 'none'.

This is part of the allocator cleanup, phase 1
(see http://bit.ly/allocator-cleanup).
After this CL, the various gyp targets are still conditionally
depending on allocator.gyp. Those will be cleaned up in subsequent
CLs.

The effect of this CL can be seen in the diff ninja files:
os=mac:                          http://pastebin.com/UWvGRUz3
os=mac component=shared_library  http://pastebin.com/E8cdSZDe

The only difference there is that the targets 'allocator' and
'allocator_unittest' are not built anymore. Previously they where
built but not depended on.

BUG=564618
==========

[Primiano Tucci (use gerrit), 2015-12-03 17:14:25]

Description was changed from

==========
allocator cleanup: set use_allocator=none for mac and ios

Conversely to what the title suggests, this CL doesn't have 
any real effect on mac/ios.
Rationale: today mac/ios have use_allocator:tcmalloc just because that
(tcmalloc) is the default value in common.gypi.
As a matter of facts, all the targets that include allocator.gyp
are conditioned by the flags os=win or os=linux (or variants)
and never actually depend on allocator on mac/ios.
This is already the situation in gn (see build/config/allocator.gni)

In essence this CL just re-establishes order in the value of
use_allocator on mac/ios in GYP, setting it to 'none'.

This is part of the allocator cleanup, phase 1
(see http://bit.ly/allocator-cleanup).
After this CL, the various gyp targets are still conditionally
depending on allocator.gyp. Those will be cleaned up in subsequent
CLs.

The effect of this CL can be seen in the diff ninja files:
os=mac:                          http://pastebin.com/UWvGRUz3
os=mac component=shared_library  http://pastebin.com/E8cdSZDe

The only difference there is that the targets 'allocator' and
'allocator_unittest' are not built anymore. Previously they where
built but not depended on.

BUG=564618
==========

to

==========
allocator cleanup: set use_allocator=none for mac and ios

Conversely to what the title suggests, this CL doesn't have 
any real effect on mac/ios.
Rationale: today mac/ios have use_allocator:tcmalloc just because that
(tcmalloc) is the default value in common.gypi.
As a matter of facts, all the targets that include allocator.gyp
are conditioned by the flags os=win or os=linux (or variants)
and never actually depend on allocator on mac/ios.
In gn instead (see build/config/allocator.gni), use_allocator is
explicitly 'none' for mac and ios.

In essence this CL just re-establishes order in the value of
use_allocator on mac/ios in GYP, setting it to 'none'.

This is part of the allocator cleanup, phase 1
(see http://bit.ly/allocator-cleanup).
After this CL, the various gyp targets are still conditionally
depending on allocator.gyp. Those will be cleaned up in subsequent
CLs.

The effect of this CL can be seen in the diff ninja files:
os=mac:                          http://pastebin.com/UWvGRUz3
os=mac component=shared_library  http://pastebin.com/E8cdSZDe

The only difference there is that the targets 'allocator' and
'allocator_unittest' are not built anymore. Previously they where
built but not depended on.

BUG=564618
==========

[Mark Mentovai, 2015-12-03 20:38:57]

LGTM

[Nico, 2015-12-03 20:49:46]

lgtm

https://codereview.chromium.org/1497813002/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/1497813002/diff/1/build/common.gypi#newcode1898
build/common.gypi:1898: 'use_allocator%': 'none',
Maybe add a short comment what this means (we use the system allocator)

[Primiano Tucci (use gerrit), 2015-12-04 09:31:58]

The CQ bit was checked by primiano@chromium.org

[Primiano Tucci (use gerrit), 2015-12-04 09:31:58]

The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org,
thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1497813002/#ps20001
(title: "add comment")

[Primiano Tucci (use gerrit), 2015-12-04 09:32:17]

The CQ bit was unchecked by primiano@chromium.org

[Primiano Tucci (use gerrit), 2015-12-04 09:32:36]

The CQ bit was checked by primiano@chromium.org

[commit-bot: I haz the power, 2015-12-04 09:32:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1497813002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1497813002/20001

[Primiano Tucci (use gerrit), 2015-12-04 09:36:07]

+ssid FYI

[commit-bot: I haz the power, 2015-12-04 10:47:09]

Description was changed from

==========
allocator cleanup: set use_allocator=none for mac and ios

Conversely to what the title suggests, this CL doesn't have 
any real effect on mac/ios.
Rationale: today mac/ios have use_allocator:tcmalloc just because that
(tcmalloc) is the default value in common.gypi.
As a matter of facts, all the targets that include allocator.gyp
are conditioned by the flags os=win or os=linux (or variants)
and never actually depend on allocator on mac/ios.
In gn instead (see build/config/allocator.gni), use_allocator is
explicitly 'none' for mac and ios.

In essence this CL just re-establishes order in the value of
use_allocator on mac/ios in GYP, setting it to 'none'.

This is part of the allocator cleanup, phase 1
(see http://bit.ly/allocator-cleanup).
After this CL, the various gyp targets are still conditionally
depending on allocator.gyp. Those will be cleaned up in subsequent
CLs.

The effect of this CL can be seen in the diff ninja files:
os=mac:                          http://pastebin.com/UWvGRUz3
os=mac component=shared_library  http://pastebin.com/E8cdSZDe

The only difference there is that the targets 'allocator' and
'allocator_unittest' are not built anymore. Previously they where
built but not depended on.

BUG=564618
==========

to

==========
allocator cleanup: set use_allocator=none for mac and ios

Conversely to what the title suggests, this CL doesn't have 
any real effect on mac/ios.
Rationale: today mac/ios have use_allocator:tcmalloc just because that
(tcmalloc) is the default value in common.gypi.
As a matter of facts, all the targets that include allocator.gyp
are conditioned by the flags os=win or os=linux (or variants)
and never actually depend on allocator on mac/ios.
In gn instead (see build/config/allocator.gni), use_allocator is
explicitly 'none' for mac and ios.

In essence this CL just re-establishes order in the value of
use_allocator on mac/ios in GYP, setting it to 'none'.

This is part of the allocator cleanup, phase 1
(see http://bit.ly/allocator-cleanup).
After this CL, the various gyp targets are still conditionally
depending on allocator.gyp. Those will be cleaned up in subsequent
CLs.

The effect of this CL can be seen in the diff ninja files:
os=mac:                          http://pastebin.com/UWvGRUz3
os=mac component=shared_library  http://pastebin.com/E8cdSZDe

The only difference there is that the targets 'allocator' and
'allocator_unittest' are not built anymore. Previously they where
built but not depended on.

BUG=564618
==========

[commit-bot: I haz the power, 2015-12-04 10:47:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-04 10:48:11]

Description was changed from

==========
allocator cleanup: set use_allocator=none for mac and ios

Conversely to what the title suggests, this CL doesn't have 
any real effect on mac/ios.
Rationale: today mac/ios have use_allocator:tcmalloc just because that
(tcmalloc) is the default value in common.gypi.
As a matter of facts, all the targets that include allocator.gyp
are conditioned by the flags os=win or os=linux (or variants)
and never actually depend on allocator on mac/ios.
In gn instead (see build/config/allocator.gni), use_allocator is
explicitly 'none' for mac and ios.

In essence this CL just re-establishes order in the value of
use_allocator on mac/ios in GYP, setting it to 'none'.

This is part of the allocator cleanup, phase 1
(see http://bit.ly/allocator-cleanup).
After this CL, the various gyp targets are still conditionally
depending on allocator.gyp. Those will be cleaned up in subsequent
CLs.

The effect of this CL can be seen in the diff ninja files:
os=mac:                          http://pastebin.com/UWvGRUz3
os=mac component=shared_library  http://pastebin.com/E8cdSZDe

The only difference there is that the targets 'allocator' and
'allocator_unittest' are not built anymore. Previously they where
built but not depended on.

BUG=564618
==========

to

==========
allocator cleanup: set use_allocator=none for mac and ios

Conversely to what the title suggests, this CL doesn't have
any real effect on mac/ios.
Rationale: today mac/ios have use_allocator:tcmalloc just because that
(tcmalloc) is the default value in common.gypi.
As a matter of facts, all the targets that include allocator.gyp
are conditioned by the flags os=win or os=linux (or variants)
and never actually depend on allocator on mac/ios.
In gn instead (see build/config/allocator.gni), use_allocator is
explicitly 'none' for mac and ios.

In essence this CL just re-establishes order in the value of
use_allocator on mac/ios in GYP, setting it to 'none'.

This is part of the allocator cleanup, phase 1
(see http://bit.ly/allocator-cleanup).
After this CL, the various gyp targets are still conditionally
depending on allocator.gyp. Those will be cleaned up in subsequent
CLs.

The effect of this CL can be seen in the diff ninja files:
os=mac:                          http://pastebin.com/UWvGRUz3
os=mac component=shared_library  http://pastebin.com/E8cdSZDe

The only difference there is that the targets 'allocator' and
'allocator_unittest' are not built anymore. Previously they where
built but not depended on.

BUG=564618

Committed: https://crrev.com/79a9c7f80d3059e696b8c8dd0e00546f3fa6edf8
Cr-Commit-Position: refs/heads/master@{#363182}
==========

[commit-bot: I haz the power, 2015-12-04 10:48:11]

Patchset 2 (id:??) landed as
https://crrev.com/79a9c7f80d3059e696b8c8dd0e00546f3fa6edf8
Cr-Commit-Position: refs/heads/master@{#363182}