components/domain_reliability/beacon.h - Issue 1497803004: Domain Reliability: Add sample_rate field to Beacon

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/domain_reliability/beacon.h

Issue 1497803004: Domain Reliability: Add sample_rate field to Beacon (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ...actually make sample_rate a double :P Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/domain_reliability/beacon.h

diff --git a/components/domain_reliability/beacon.h b/components/domain_reliability/beacon.h

index 0822c742761747bf00347aef5ecf279b44f35633..1cb88e19e73395af2ec0ca716631d5488510499f 100644

--- a/components/domain_reliability/beacon.h

+++ b/components/domain_reliability/beacon.h

@@ -68,6 +68,8 @@ struct DOMAIN_RELIABILITY_EXPORT DomainReliabilityBeacon {

// caused by an upload that itself contained no beacons caused by uploads,

// et cetera.

int upload_depth;

+ // The probability that this request had of being reported ("sample rate").

+ double sample_rate;

jkarlin 2015/12/09 11:46:22 This should have been caught by a test. Need moar

Deprecated (see juliatuttle) 2015/12/10 17:04:23 Done.

// Okay to copy and assign.

};

« no previous file with comments | « no previous file | components/domain_reliability/beacon.cc » ('j') | components/domain_reliability/config.h » ('J')