Domain Reliability: Add sample_rate field to Beacon

components/domain_reliability/context_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/domain_reliability/context.h"
 
 #include <map>
 #include <string>
 
 #include "base/bind.h"
@@ skipping 18 matching lines @@
   beacon->status = "tcp.connection_reset";
   beacon->chrome_error = net::ERR_CONNECTION_RESET;
   beacon->server_ip = "127.0.0.1";
   beacon->was_proxied = false;
   beacon->protocol = "HTTP";
   beacon->details.quic_broken = true;
   beacon->http_response_code = -1;
   beacon->elapsed = base::TimeDelta::FromMilliseconds(250);
   beacon->start_time = time->NowTicks() - beacon->elapsed;
   beacon->upload_depth = 0;
+  beacon->sample_rate = 1.0;
   return beacon.Pass();
 }
 
 class DomainReliabilityContextTest : public testing::Test {
  protected:
   DomainReliabilityContextTest()
       : last_network_change_time_(time_.NowTicks()),
         dispatcher_(&time_),
         params_(MakeTestSchedulerParams()),
         uploader_(base::Bind(&DomainReliabilityContextTest::OnUploadRequest,
@@ skipping 158 matching lines @@
   BeaconVector beacons;
   context_.GetQueuedBeaconsForTesting(&beacons);
   EXPECT_EQ(1u, beacons.size());
 
   // N.B.: Assumes max_delay is 5 minutes.
   const char* kExpectedReport = "{"
     "\"entries\":["
       "{\"failure_data\":{\"custom_error\":\"net::ERR_CONNECTION_RESET\"},"
       "\"network_changed\":false,\"protocol\":\"HTTP\","
       "\"quic_broken\":true,\"request_age_ms\":300250,"
-      "\"request_elapsed_ms\":250,"
+      "\"request_elapsed_ms\":250,\"sample_rate\":1.0,"
       "\"server_ip\":\"127.0.0.1\",\"status\":\"tcp.connection_reset\","
-      "\"url\":\"https://localhost/\","
-      "\"was_proxied\":false}],\"reporter\":\"test-reporter\"}";
+      "\"url\":\"https://localhost/\",\"was_proxied\":false}],"
+      "\"reporter\":\"test-reporter\"}";
 
   time_.Advance(max_delay());
   EXPECT_TRUE(upload_pending());
   EXPECT_EQ(kExpectedReport, upload_report());
   EXPECT_EQ(0, upload_max_depth());
   EXPECT_EQ(GURL("https://exampleuploader/upload"), upload_url());
 
   DomainReliabilityUploader::UploadResult result;
   result.status = DomainReliabilityUploader::UploadResult::SUCCESS;
   CallUploadCallback(result);
 
   EXPECT_TRUE(CheckNoBeacons());
 }
 
 TEST_F(DomainReliabilityContextTest, Upload_NetworkChanged) {
   context_.OnBeacon(MakeBeacon(&time_));
 
   BeaconVector beacons;
   context_.GetQueuedBeaconsForTesting(&beacons);
   EXPECT_EQ(1u, beacons.size());
 
   // N.B.: Assumes max_delay is 5 minutes.
   const char* kExpectedReport = "{"
     "\"entries\":["
       "{\"failure_data\":{\"custom_error\":\"net::ERR_CONNECTION_RESET\"},"
       "\"network_changed\":true,\"protocol\":\"HTTP\","
       "\"quic_broken\":true,\"request_age_ms\":300250,"
-      "\"request_elapsed_ms\":250,"
+      "\"request_elapsed_ms\":250,\"sample_rate\":1.0,"

[jkarlin, 2015/12/09 11:46:22]

Needs more tests. Include rates such as 0.0, 1.0, 0.33, and out of bounds checks
like -5 and 50. Also, shouldn't there be tests for success sample rates and
failure sample rates?

[Deprecated (see juliatuttle), 2015/12/10 17:04:23]

I've added tests for 0.0 and 0.5 (1.0 is tested implicitly, as it's the default
in the tests).

Out of bounds checks are handled before the Config gets here. Right now,
anything negative behaves as if it's 0.0, and anything above 1.0 behaves as if
it's 1.0. Does that seem reasonable, and does it need explicit testing?

       "\"server_ip\":\"127.0.0.1\",\"status\":\"tcp.connection_reset\","
-      "\"url\":\"https://localhost/\","
-      "\"was_proxied\":false}],\"reporter\":\"test-reporter\"}";
+      "\"url\":\"https://localhost/\",\"was_proxied\":false}],"
+      "\"reporter\":\"test-reporter\"}";
 
   // Simulate a network change after the request but before the upload.
   last_network_change_time_ = time_.NowTicks();
   time_.Advance(max_delay());
   EXPECT_TRUE(upload_pending());
   EXPECT_EQ(kExpectedReport, upload_report());
   EXPECT_EQ(0, upload_max_depth());
   EXPECT_EQ(GURL("https://exampleuploader/upload"), upload_url());
 
   DomainReliabilityUploader::UploadResult result;
   result.status = DomainReliabilityUploader::UploadResult::SUCCESS;
   CallUploadCallback(result);
 
   EXPECT_TRUE(CheckNoBeacons());
 }
 
 // TODO(ttuttle): Add beacon_unittest.cc to test serialization.
 
 }  // namespace
 }  // namespace domain_reliability